Bug 485210 - Split View dropdown menu actions of an inactive special (diff) view act on active view
Summary: Split View dropdown menu actions of an inactive special (diff) view act on a...
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (other bugs)
Version First Reported In: 24.02.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-08 00:17 UTC by Grósz Dániel
Modified: 2024-09-15 18:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Grósz Dániel 2024-04-08 00:17:09 UTC
SUMMARY
Normally, the actions in the small Split View dropdown menu at the end of a tab bar or navigation bar act on the split view the tool button belongs to, regardless of which view is active (as is expected if there's a separate menu for each split view). However, if that split view has a special view (a diff, Welcome, or an expanded Find in Files result view), and another split is active, the actions act on the active view.

Curiously, clicking inside a diff view, and then on the Split View menu button, makes the menu act on the diff view, even though clicking inside the diff view doesn't activate it for all purposes (see Bug 485209).

STEPS TO REPRODUCE
1. Create a split (I used Split Vertical).
2. Open a diff view (I did it using the Git sidebar).
3. Click inside another split view (which contains a regular editor).
4. Click on the small Split View icon at the end of the tab bar of the diff view.
5. Click Hide Inactive Views (or Split Horizontal etc.)

OBSERVED RESULT
The view in the other side (not the diff view) of the split fills the window (or gets further split horizontally etc).

EXPECTED RESULT
The diff view fills the window (or gets further split horizontally etc).

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20240404
KDE Plasma Version: 6.0.3
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.3
Kernel Version: 6.8.2-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Seems related to Bug 485209.
Comment 1 Christoph Cullmann 2024-09-15 17:50:31 UTC
Can confirm that, fixed some internal issues with view space activation, but this still persists.
Comment 2 Christoph Cullmann 2024-09-15 18:32:21 UTC
Git commit be5fd2a4e9f93f30f123e9d12a30b7bf214c5a39 by Christoph Cullmann.
Committed on 15/09/2024 at 18:32.
Pushed by cullmann into branch 'master'.

fix focus for widgets

now the menu actions of the split buttons
in the view space trigger the split stuff for the right
view space

M  +5    -5    apps/lib/katemainwindow.cpp
M  +1    -0    apps/lib/kateviewspace.cpp

https://invent.kde.org/utilities/kate/-/commit/be5fd2a4e9f93f30f123e9d12a30b7bf214c5a39