Bug 485140 - [View Source] element in context menu is shown only for attachments(images) but not for text messages
Summary: [View Source] element in context menu is shown only for attachments(images) b...
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (show other bugs)
Version: 24.02.1
Platform: Flatpak Linux
: NOR normal
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-06 16:51 UTC by Bohdan Mart
Modified: 2024-04-07 08:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
When I am clicking on message that is Image attachment (m.image) (22.20 KB, image/png)
2024-04-06 16:51 UTC, Bohdan Mart
Details
When I am clicking on text message that has no media attachments (13.20 KB, image/png)
2024-04-06 16:52 UTC, Bohdan Mart
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bohdan Mart 2024-04-06 16:51:26 UTC
Created attachment 168223 [details]
When I am clicking on message that is Image attachment (m.image)

SUMMARY
I can only view source of attachment messages. (Tested on regular files and on images)

STEPS TO REPRODUCE
1. Open chat room
2. Create new messages or scroll room util you see any attachment or image
3. Right click on it
4. Click View Source
5. Right click on nay textual message
6. There are no button View Source

OBSERVED RESULT
No [view source] menu item for textual messages. Only for attachemnts, Images and Files ("m.image" and "m.file")

EXPECTED RESULT
Being able to "View Source" of ANY message, same as on other DESKTOP matrix clients. At least thing I have observed in Element based clients, and what I like about Matrix.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:   Manjaro KDE
(available in About System) 
Host:
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12
flatpak:
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2

ADDITIONAL INFORMATION

Initially I've noticed this on images, but it works for files as well.
Comment 1 Bohdan Mart 2024-04-06 16:52:15 UTC
Created attachment 168224 [details]
When I am clicking on text message that has no media attachments
Comment 2 Bug Janitor Service 2024-04-06 18:14:49 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1673
Comment 3 James Graham 2024-04-06 18:16:13 UTC
So in case you miss it we only show the message source option when devtools is on. The patch makes that consistent which clearly wasn't happening in 24.02
Comment 4 Bohdan Mart 2024-04-06 18:33:55 UTC
Ok. Good for me, if it would be consistent.

Especially if it is possible to enable dev-tools somehow.
Comment 5 James Graham 2024-04-07 08:40:18 UTC
Git commit f58c390a4702089c5f70ba47862407fb4923e67c by James Graham.
Committed on 07/04/2024 at 08:40.
Pushed by nvrwhere into branch 'master'.

Re-add requirement for having devtools active for the show message source action

Re-add requirement for having devtools active for the show message source action

M  +1    -0    src/qml/DelegateContextMenu.qml

https://invent.kde.org/network/neochat/-/commit/f58c390a4702089c5f70ba47862407fb4923e67c