Bug 484982 - Show close button on split view
Summary: Show close button on split view
Status: REPORTED
Alias: None
Product: dolphin
Classification: Applications
Component: split view (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-03 14:06 UTC by Michi
Modified: 2024-04-08 18:22 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michi 2024-04-03 14:06:51 UTC
No matter which closing behaviour I configure, I always end up messing with which side of the split view gets closed. Also the icon doesn't help much. To begin with, you have to realize that it indicates which side of the view will be closed. But even then, you always have to think twice what you have to do.

My suggestion would be a simple close button on each side of the view. There's no mental burden attached to it and you don't need extra icons, nor do you need the extra config parameter.

thx Michi
Comment 1 Felix Ernst 2024-04-08 13:20:27 UTC
Hi, we are aware of this problem. However, the solution I currently favour is that we would show a big red "X" spanning the whole view whenever the user hovers the mouse cursor over the "Close [Split View]" button. This way we wouldn't need extra space by default only to show a close button. Would an indicator on hover in your opinion also fix your problem?
Comment 2 Michi 2024-04-08 16:05:38 UTC
(In reply to Felix Ernst from comment #1)
> Hi, we are aware of this problem. However, the solution I currently favour
> is that we would show a big red "X" spanning the whole view whenever the
> user hovers the mouse cursor over the "Close [Split View]" button. This way
> we wouldn't need extra space by default only to show a close button. Would
> an indicator on hover in your opinion also fix your problem?

First of all thx for your time. In my opinion I do not like the idea. It only shows more prominently that I am trying to do the wrong thing. So in the end I still have to "refocus" - literally. And honestly, the places panel, the console panel, all have a close button. I don't understand what's different about the split view?

Hope this makes sense ...
Comment 3 Felix Ernst 2024-04-08 17:15:26 UTC
(In reply to Michi from comment #2)
> First of all thx for your time.

You are welcome!

>And honestly, the places panel, the console panel, all have a close button.
>I don't understand what's different about the split view?

Well, actually by default none of them have a close button. There is the action "Un/Lock Panels" which decides whether those panels have an extra bar with a close button. By default, all of these bars are hidden and there is no visible close button for any of those panels. You can find the "Lock Panels" action in the menu bar in View->Show Panels or if you don't have a menu bar enabled in Open Menu->Show Panels.

So we actually don't want to introduce extra bars by default only to have close buttons there.

>In my opinion I do not like the idea. It
> only shows more prominently that I am trying to do the wrong thing. So in
> the end I still have to "refocus" - literally.

> Hope this makes sense ...

It does make sense. This is a bit of a question whether one values this specific issue more highly than the lost screen space by having an extra bar. I wouldn't want to add an extra bar that takes away from the main view, so that's why I came up with the idea of only showing what will happen on hover.
Comment 4 Felix Ernst 2024-04-08 17:28:45 UTC
Hmm, actually now that I think about it, it probably wouldn't be too difficult to add such bars only while in split view mode and only when panels are "unlocked". I wonder if there are many users who would prefer that (aside from Michi 😄).
Comment 5 Felix Ernst 2024-04-08 18:22:00 UTC
(In reply to Felix Ernst from comment #4)
> Hmm, actually now that I think about it, it probably wouldn't be too
> difficult to add such bars only while in split view mode

Actually, better than an extra bar would probably be if we added them at the end of the location bar (in dolphinnavigatorswidgetaction.cpp). Still not sure though if there would be many users who would like this. Considering that it might be better to have this disabled by default, even people who might like this might not think about enabling it.