When you launch a fresh Elisa instance, and select Files category, it's shown empty and if you try to click on that "Add to playlist" button Elisa will close itself. Operating System: Manjaro Linux KDE Plasma Version: 6.0.3 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.3 Kernel Version: 6.8.2-2-MANJARO (64-bit) Graphics Platform: Wayland
Where is all your music located?
(In reply to Nate Graham from comment #1) > Where is all your music located? My whole music library is on a separate NTFS partition where it can be used both from Manjaro and Windows10. But this problem happens with fresh Elisa without any added music library.
What path is the files tab showing when you click the Add to Playlist button? And are there any music files, or subdirectories in this folder?
Created attachment 169459 [details] Files tab empty (In reply to Jack Hill from comment #3) > What path is the files tab showing when you click the Add to Playlist > button? Nothing appears in Files tab. > And are there any music files, or subdirectories in this folder? I didn't add yet any music. See my attached video for more info.
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/579
Thank you for the video. I think this is two issues in one: 1. Clicking the play button on an empty files tab crashes Elisa. This should be fixed in the above merge request. 2. The files tab is displaying files from `~/Music` but this is not made obvious to the user. I think the Files tab should (1) display the current file path to the user, and maybe (2) have a button for navigating to the parent directory for easier navigation. Btw it is possible to change the default file path of the Files tab in the config window.
Browsing music files by using the structure of system files is an essential tool for many users, because when you import a big list of songs from multiple parts, it gets difficult to tag all of them using special tools like kid3, so some users simply organize them inside named folders. It would be great if file browser inside Elisa first starts pointing to that initial folder set in settings, then it will remember the last visited location upon each start, and if it's lost then reset it to that initial folder. And it would awesome if even those music folders added in settings appears at top inside a combobox to make it easy to navigate inside them.
And like you said the current opened folder path should be made visible at top like in Dolphin, with "go back", "go forward" and "go up" buttons to get full browsing capabilities.
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/580
Git commit 87ef42ed7864582c7c9899def66ab56d656aa8a3 by Jack Hill. Committed on 07/06/2024 at 19:58. Pushed by jackh into branch 'master'. Fix potential crash when enqueueing from empty files view If the current folder is empty, then mPendingEntries will be empty. Calling front on an empty queue is undefined behaviour, and can result in a crash. Test-plan: added an autotest Related: bug 441525 M +11 -0 autotests/CMakeLists.txt A +86 -0 autotests/filebrowserproxymodeltest.cpp [License: LGPL(v3.0+)] M +6 -7 src/models/filebrowserproxymodel.cpp https://invent.kde.org/multimedia/elisa/-/commit/87ef42ed7864582c7c9899def66ab56d656aa8a3
Git commit 246178d77c77f89a430829e5113ffd20805acb54 by Jack Hill. Committed on 08/06/2024 at 11:10. Pushed by ngraham into branch 'release/24.05'. Fix potential crash when enqueueing from empty files view If the current folder is empty, then mPendingEntries will be empty. Calling front on an empty queue is undefined behaviour, and can result in a crash. Test-plan: added an autotest Related: bug 441525 (cherry picked from commit 87ef42ed7864582c7c9899def66ab56d656aa8a3) M +11 -0 autotests/CMakeLists.txt A +86 -0 autotests/filebrowserproxymodeltest.cpp [License: LGPL(v3.0+)] M +6 -7 src/models/filebrowserproxymodel.cpp https://invent.kde.org/multimedia/elisa/-/commit/246178d77c77f89a430829e5113ffd20805acb54
Git commit fdd903291bc8e14aa3ac92f6d6afea67f316a44e by Nate Graham, on behalf of Jack Hill. Committed on 30/06/2024 at 16:39. Pushed by ngraham into branch 'master'. Don't allow enqueueing all items in a view if the view is empty Prevents the user from triggering a crash when enqueueing in an empty Files view. Test-plan: - Set Elisa to index an empty directory, go into albums view, try to enqueue all items - Use the Files view to navigate into an empty directory, try to enqueue all items Before: crash when enqueuing from files, nothing happens when enqueuing from albums view Now: buttons to enqueue are disabled Related: bug 484665 M +1 -0 src/qml/AbstractDataView.qml M +3 -0 src/qml/NavigationActionBar.qml https://invent.kde.org/multimedia/elisa/-/commit/fdd903291bc8e14aa3ac92f6d6afea67f316a44e