Bug 484946 - FTBFS with Qt 6.7
Summary: FTBFS with Qt 6.7
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (show other bugs)
Version: 8.3.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-02 20:47 UTC by Antonio Rojas
Modified: 2024-04-10 10:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2024-04-02 20:47:54 UTC
Build fails with Qt 6.7 and GCC 13:

In file included from /usr/include/qt6/QtCore/QtCore:238,
                 from /usr/include/qt6/QtDBus/QtDBusDepends:3,
                 from /usr/include/qt6/QtDBus/QtDBus:3,
                 from /build/digikam/src/digikam-8.3.0/core/libs/database/coredb/coredbwatch.cpp:24:
/usr/include/qt6/QtCore/qspan.h:300:5: error: "__cpp_lib_span" is not defined, evaluates to 0 [-Werror=undef]
  300 | #if __cpp_lib_span
      |     ^~~~~~~~~~~~~~

"-Werror=undef" comes from extra-cmake-modules. "__cpp_lib_span" is defined with C++20 only, and digikam enforces C++17 in CMakeLists.txt
Comment 1 Antonio Rojas 2024-04-02 21:22:28 UTC
Qt bug: https://bugreports.qt.io/browse/QTBUG-123937
Comment 2 Nicolas Fella 2024-04-06 13:13:18 UTC
*** Bug 485131 has been marked as a duplicate of this bug. ***
Comment 3 caulier.gilles 2024-04-10 08:03:54 UTC
Git commit 28eab40d868f4bb20fc6f04b99673d7558fe614e by Gilles Caulier.
Committed on 10/04/2024 at 08:01.
Pushed by cgilles into branch 'master'.

fix broken compillation with Qt 6.7
Related: bug 485131
FIXED-IN: 8.4.0

M  +1    -1    CMakeLists.txt
M  +2    -2    NEWS

https://invent.kde.org/graphics/digikam/-/commit/28eab40d868f4bb20fc6f04b99673d7558fe614e
Comment 4 caulier.gilles 2024-04-10 09:17:18 UTC
Git commit 01467beb4e0bf83e183aa48116249f76fd7a026c by Gilles Caulier.
Committed on 10/04/2024 at 09:14.
Pushed by cgilles into branch 'master'.

Fix compilation with C++20
UPNP SDK only support C++17
Related: bug 485131

M  +5    -0    core/dplugins/generic/tools/mediaserver/CMakeLists.txt

https://invent.kde.org/graphics/digikam/-/commit/01467beb4e0bf83e183aa48116249f76fd7a026c
Comment 5 caulier.gilles 2024-04-10 10:09:49 UTC
Git commit ae7afd5a4aca105c93f67d3f0bde18dbe23069af by Gilles Caulier.
Committed on 10/04/2024 at 10:09.
Pushed by cgilles into branch 'master'.

Fix compilation with C++20
UPNP SDK unit test only support C++17
Related: bug 485131

M  +2    -0    core/tests/mediaserver/CMakeLists.txt

https://invent.kde.org/graphics/digikam/-/commit/ae7afd5a4aca105c93f67d3f0bde18dbe23069af