Bug 484855 - basket-2.49b fails to compile with libgit2-1.8.0
Summary: basket-2.49b fails to compile with libgit2-1.8.0
Status: REPORTED
Alias: None
Product: basket
Classification: Applications
Component: general (show other bugs)
Version: 2.0-git
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: veggero
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-01 08:14 UTC by Zoltan Puskas
Modified: 2024-05-16 12:35 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Puskas 2024-04-01 08:14:12 UTC 
SUMMARY

Basket fails to compile with libgit2-1.8.0 when git integration is enabled.

STEPS TO REPRODUCE
1. Try to build basket with latest libgit2

OBSERVED RESULT

Compilation fails with:

/var/tmp/portage/kde-misc/basket-2.49b/work/basket-2.49b/src/gitwrapper.cpp: In static member function ‘static bool GitWrapper::commitIndex(git_repository*, git_index*, QString)’:
/var/tmp/portage/kde-misc/basket-2.49b/work/basket-2.49b/src/gitwrapper.cpp:366:104: error: invalid conversion from ‘const git_commit**’ to ‘git_commit* const*’ [-fpermissive]
  366 |     error = git_commit_create(&commit_id, repo, "HEAD", sig, sig, NULL, commitmessageCString, tree, 1, parentarray);
      |                                                                                                        ^~~~~~~~~~~
      |                                                                                                        |
      |                                                                                                        const git_commit**
In file included from /usr/include/git2/repository.h:14,
                 from /usr/include/git2/annotated_commit.h:11,
                 from /usr/include/git2.h:11,
                 from /var/tmp/portage/kde-misc/basket-2.49b/work/basket-2.49b/src/gitwrapper.cpp:14:
/usr/include/git2/commit.h:369:28: note:   initializing argument 10 of ‘int git_commit_create(git_oid*, git_repository*, const char*, const git_signature*, const git_signature*, const char*, const char*, const git_tree*, size_t, git_commit* const*)’
  369 |         git_commit * const parents[]);
      |         ~~~~~~~~~~~~~~~~~~~^~~~~~~~~

EXPECTED RESULT

Successful build.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Gentoo Linux (6.7.9-gentoo (64-bit))
(available in About System)
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.13

ADDITIONAL INFORMATION

Please see Gentoo bug report for full build log: https://bugs.gentoo.org/928338
Release notes for libgit2 with ABI breaking changes: https://github.com/libgit2/libgit2/releases/tag/v1.8.0