Created attachment 167967 [details] Application tab lack internal margins When you right-click on any icon in Application Launcher then select "Edit Application", Application tab lacks some internal margins. See attached image for more info. Operating System: Manjaro Linux KDE Plasma Version: 6.0.3 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Kernel Version: 6.8.2-1-MANJARO (64-bit) Graphics Platform: Wayland
Can reproduce. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 6.0.3 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Graphics Platform: Wayland
Opened a MR: https://invent.kde.org/frameworks/kio/-/merge_requests/1644 Maybe bringing the tab frame back completely would be ideal though.
(In reply to Thomas Duckworth from comment #2) > Opened a MR: https://invent.kde.org/frameworks/kio/-/merge_requests/1644 > > Maybe bringing the tab frame back completely would be ideal though. It's clearly a regression that happened with Plasma 6, many apps using tab have lost the external margins of grouped tabs, and also lost the internal margins inside each tab.
(In reply to medin from comment #3) > (In reply to Thomas Duckworth from comment #2) > > Opened a MR: https://invent.kde.org/frameworks/kio/-/merge_requests/1644 > > > > Maybe bringing the tab frame back completely would be ideal though. > > It's clearly a regression that happened with Plasma 6, many apps using tab > have lost the external margins of grouped tabs, and also lost the internal > margins inside each tab. This also occurs on the URL tab, which I have restored margins to. I have also restored margins to the Permissions tab for the internal groups.
*** Bug 485508 has been marked as a duplicate of this bug. ***
Git commit b425985c9c5845d304a4461929656bbd937c3a01 by Carl Schwan, on behalf of Thomas Duckworth. Committed on 05/10/2024 at 22:51. Pushed by carlschwan into branch 'master'. Clean up Properties dialog to follow HIG, improve UX, remove frames and fix padding regression Plasma 6 introduced a regression in this dialog where there are no longer proper margins in most tabs, due to the move to a frameless style. This makes specifically URL and Application properties tabs look quite bad, as they end up with text glyphs right up against the edge of the window. Explicit 0px margins are removed, instead leaving the layouts to inherit from the stylesheet, which also improves maintainability. The dialog can no longer be shrunk to the point where the tab contents look broken. In the Permissions pane, the QGroupBox is now flat, so it looks the same as Kirigami.FormLayout, and doesn't have unnecessary frames. It's also ported to QFormLayout. QLabel in KChecksumsPlugin is now a readonly QLineEdit, as this shows a nice looking box, and doesn't unexpectedly expand the window by an insane amount, where it can't be resized back down to a normal size. M +4 -4 src/widgets/checksumswidget.ui M +1 -0 src/widgets/kacleditwidget.cpp M +0 -12 src/widgets/kpropertiesdesktopadvbase.ui M +0 -3 src/widgets/kpropertiesdesktopbase.ui M +3 -0 src/widgets/kpropertiesdialog.cpp M +59 -55 src/widgets/kpropertiesdialogbuiltin_p.cpp M +2 -2 src/widgets/kpropertiesdialogbuiltin_p.h https://invent.kde.org/frameworks/kio/-/commit/b425985c9c5845d304a4461929656bbd937c3a01