Bug 484679 - Animation Curves: Keyframes are added on a frame depending on where the caching is currently, not where the timeslider is at.
Summary: Animation Curves: Keyframes are added on a frame depending on where the cachi...
Status: RESOLVED WORKSFORME
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 5.2.2
Platform: Compiled Sources Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 486324 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-03-28 18:39 UTC by Sebastian Haas
Modified: 2024-10-10 21:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
State of the Animation Timeline explaining where keyframes should and where they did appear (57.21 KB, image/png)
2024-03-28 18:39 UTC, Sebastian Haas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Haas 2024-03-28 18:39:02 UTC
Created attachment 167900 [details]
State of the Animation Timeline explaining where keyframes should and where they did appear

SUMMARY
I have a group layer, with two paint layers. I wish to animate the group's position. To do this I added a Transform Mask, went into the Animation Timeline and pressed the "Adds Keyframe to scalar property button", with the timeslider set to frame 0. This added keyframes to all the Transform Layers properties.

If I  then set the timeslider to another frame, and try to "Adds Keyframe to scalar property button", this can only update keyframe 0. If the caching of the animation is running, I can add keyframes to different frames, but now the frame the keyframe is added to is whereever the caching is at or was last (as indicated by the little grey bars over each frame in the timeline.

Here's lines from the bug report text from within Krita, that repeated a lot during this session:

28 Mar 2024 18:24:24 +0100: SAFE ASSERT (krita): "node->hasEditablePaintDevice()" in file C:/Packaging/workspace/Krita_Release_Windows64_Build/krita/libs/ui/tool/strokes/move_stroke_strategy.cpp, line 336
28 Mar 2024 18:34:14 +0100: SAFE ASSERT (krita): "!hasTransformMaskDescendant" in file C:/Packaging/workspace/Krita_Release_Windows64_Build/krita/plugins/tools/tool_transform2/kis_transform_utils.cpp, line 679
28 Mar 2024 18:42:52 +0100: SAFE ASSERT (krita): "channelId == KisKeyframeChannel::Raster.id()" in file C:/Packaging/workspace/Krita_Release_Windows64_Build/krita/plugins/dockers/animation/KisAnimUtils.cpp, line 72
28 Mar 2024 18:46:43 +0100: SAFE ASSERT (krita): "image->animationInterface()->currentTime() == time" in file C:/Packaging/workspace/Krita_Release_Windows64_Build/krita/plugins/dockers/animation/KisAnimUtils.cpp, line 71


STEPS TO REPRODUCE
1.  Make a Group layer with a Transform Mask
2.  Go into the "Animation Curves" Docker and press the "Adds Keyframe to scalar property button" with the timeslider at frame 0
3.  Keyframes appear at frame 0
4. Move the timeslider to a different frame
5.  press the "Adds Keyframe to scalar property button" again
6. Keyframes appear at the frame that the caching starts at or is currently at

OBSERVED RESULT
Adding Keyframes appears to take the animation caching system's Current Frame as their target, not the timeslider's position, nor neither the keyframe text entry box.

EXPECTED RESULT
"Adds keyframe to..." adds keyframes at the position of the timeslider/the frame indicated in the current frame textbox.

ADDITIONAL INFORMATION
Here's the output of the Bug Report COpy&Paste text (minus the session info, I'm not comfortable sharing that, since it does contain private information, such as image names, projects I'm working on, etc...)
Krita

 Version: 5.2.2
 Installation type: installer / portable package
 Hidpi: false

Qt

  Version (compiled): 5.15.7
  Version (loaded): 5.15.7

OS Information

  Build ABI: x86_64-little_endian-llp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: winnt
  Kernel Version: 10.0.19045
  Pretty Productname: Windows 10 Version 2009
  Product Type: windows
  Product Version: 10

Locale

  Languages: en_US, en_US
  C locale: C
  QLocale current: en
  QLocale system: en
  QTextCodec for locale: UTF-8
  Process ACP: 65001 (UTF-8)
  System locale default ACP: 1252  (ANSI - Latin I)

OpenGL Info
 
  Vendor:  "NVIDIA Corporation" 
  Renderer:  "GeForce GTX 765M/PCIe/SSE2" 
  Driver version:  "4.6.0 NVIDIA 425.31" 
  Shading language:  "4.60 NVIDIA" 
  Requested format:  QSurfaceFormat(version 3.3, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::CompatibilityProfile) 
  Current format:  QSurfaceFormat(version 4.6, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples 0, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 1, colorSpace QSurfaceFormat::sRGBColorSpace, profile  QSurfaceFormat::CompatibilityProfile) 
  GL version: 4.6 
  Supports deprecated functions true 
  Is OpenGL ES: false 
  supportsBufferMapping: true 
  supportsBufferInvalidation: true 
  forceDisableTextureBuffers: false 
  Extensions: 
     GL_ARB_fragment_program 
     GL_NV_command_list 
     GL_NV_framebuffer_multisample_coverage 
     GL_NV_packed_depth_stencil 
     GL_ARB_depth_buffer_float 
     GL_ARB_shading_language_100 
     GL_ARB_multi_draw_indirect 
     GL_ARB_transform_feedback3 
     GL_NV_vertex_array_range2 
     GL_ARB_ES2_compatibility 
     GL_ARB_map_buffer_range 
     GL_ARB_draw_buffers 
     GL_ARB_gpu_shader5 
     GL_NVX_multigpu_info 
     GL_ARB_gpu_shader_fp64 
     GL_ARB_compressed_texture_pixel_storage 
     GL_NV_shader_storage_buffer_object 
     GL_NV_ES3_1_compatibility 
     GL_ARB_texture_mirror_clamp_to_edge 
     GL_EXT_texture_mirror_clamp 
     GL_ARB_shading_language_include 
     GL_EXT_texture_swizzle 
     GL_ARB_texture_buffer_object_rgb32 
     GL_NV_vertex_attrib_integer_64bit 
     GL_EXT_framebuffer_object 
     GL_ARB_pipeline_statistics_query 
     GL_ARB_shader_draw_parameters 
     GL_NV_geometry_shader4 
     GL_NV_texture_shader 
     GL_EXT_framebuffer_multisample 
     GL_ATI_texture_mirror_once 
     GL_ARB_texture_buffer_object 
     GL_ARB_map_buffer_alignment 
     GL_SGIS_texture_lod 
     GL_EXT_win32_keyed_mutex 
     GL_NV_copy_depth_to_color 
     GL_SUN_slice_accum 
     GL_ARB_get_program_binary 
     GL_EXT_texture_lod_bias 
     GL_ARB_transpose_matrix 
     GL_NV_shader_atomic_counters 
     GL_ARB_shader_image_size 
     GL_ARB_half_float_pixel 
     GL_NV_vertex_program2_option 
     GL_ARB_shader_group_vote 
     GL_ARB_copy_image 
     GL_ARB_texture_buffer_range 
     GL_WIN_swap_hint 
     GL_ARB_texture_compression 
     GL_ARB_seamless_cubemap_per_texture 
     GL_NV_register_combiners2 
     GL_EXT_texture_env_combine 
     GL_EXT_texture3D 
     GL_NV_query_resource 
     GL_ARB_conservative_depth 
     GL_ARB_texture_query_levels 
     GL_ARB_occlusion_query2 
     GL_NV_ES1_1_compatibility 
     GL_NV_primitive_restart 
     GL_EXT_texture_object 
     GL_NV_parameter_buffer_object2 
     GL_EXT_depth_bounds_test 
     GL_ARB_texture_stencil8 
     GL_EXT_blend_func_separate 
     GL_EXT_compiled_vertex_array 
     GL_ARB_enhanced_layouts 
     GL_ARB_texture_query_lod 
     GL_ARB_imaging 
     GL_EXT_vertex_attrib_64bit 
     GL_NV_parameter_buffer_object 
     GL_EXT_blend_color 
     GL_NVX_gpu_memory_info 
     GL_KHR_context_flush_control 
     GL_ARB_depth_texture 
     GL_ARB_texture_env_dot3 
     GL_NV_texture_env_combine4 
     GL_ARB_vertex_array_bgra 
     GL_ARB_arrays_of_arrays 
     GL_ARB_conditional_render_inverted 
     GL_ARB_vertex_array_object 
     GL_ARB_buffer_storage 
     GL_EXT_bindable_uniform 
     GL_OVR_multiview 
     GL_ARB_get_texture_sub_image 
     GL_ARB_texture_swizzle 
     GL_NV_internalformat_sample_query 
     GL_SGIX_depth_texture 
     GL_EXT_texture_buffer_object 
     GL_ARB_fragment_coord_conventions 
     GL_ARB_shading_language_420pack 
     GL_NV_uniform_buffer_unified_memory 
     GL_EXT_geometry_shader4 
     GL_ARB_transform_feedback_instanced 
     GL_ARB_gpu_shader_int64 
     GL_EXT_texture_compression_s3tc 
     GL_EXT_draw_instanced 
     GL_ARB_blend_func_extended 
     GL_NV_blend_equation_advanced 
     GL_ARB_sparse_buffer 
     GL_ARB_texture_rg 
     GL_EXT_draw_buffers2 
     GL_EXT_stencil_wrap 
     GL_NV_gpu_program5_mem_extended 
     GL_SGIX_shadow 
     GL_ARB_texture_filter_anisotropic 
     GL_EXT_texture_env_dot3 
     GL_ARB_texture_cube_map 
     GL_ARB_vertex_attrib_64bit 
     GL_NV_fragment_program2 
     GL_ARB_texture_rectangle 
     GL_EXT_Cg_shader 
     GL_NV_occlusion_query 
     GL_ARB_vertex_shader 
     GL_EXT_separate_specular_color 
     GL_ARB_shader_atomic_counter_ops 
     GL_ARB_vertex_type_2_10_10_10_rev 
     GL_ARB_ES3_2_compatibility 
     GL_ARB_draw_indirect 
     GL_ARB_timer_query 
     GL_ARB_texture_mirrored_repeat 
     GL_EXT_packed_float 
     GL_EXT_gpu_program_parameters 
     GL_NV_texgen_reflection 
     GL_ARB_shader_texture_image_samples 
     GL_EXT_texture_compression_dxt1 
     GL_NV_fragment_program_option 
     GL_EXT_packed_pixels 
     GL_IBM_rasterpos_clip 
     GL_ARB_point_sprite 
     GL_ARB_texture_compression_rgtc 
     GL_ARB_clear_buffer_object 
     GL_NV_fence 
     GL_NV_transform_feedback 
     GL_ARB_half_float_vertex 
     GL_KHR_robust_buffer_access_behavior 
     GL_ARB_bindless_texture 
     GL_EXT_texture_cube_map 
     GL_EXT_texture_sRGB_R8 
     GL_ARB_texture_non_power_of_two 
     GL_ARB_fragment_shader 
     GL_ARB_invalidate_subdata 
     GL_EXT_pixel_buffer_object 
     GL_ARB_compute_variable_group_size 
     GL_ARB_vertex_attrib_binding 
     GL_ARB_cull_distance 
     GL_ARB_shader_clock 
     GL_ARB_draw_instanced 
     GL_EXT_polygon_offset_clamp 
     GL_NV_multisample_coverage 
     GL_NV_vertex_program2 
     GL_NV_gpu_shader5 
     GL_ARB_instanced_arrays 
     GL_NVX_nvenc_interop 
     GL_ARB_shading_language_packing 
     GL_NV_bindless_texture 
     GL_NV_float_buffer 
     GL_NV_vertex_program3 
     GL_ARB_texture_cube_map_array 
     GL_ARB_texture_border_clamp 
     GL_EXT_abgr 
     GL_EXTX_framebuffer_mixed_formats 
     GL_ARB_direct_state_access 
     GL_SGIS_generate_mipmap 
     GL_ARB_debug_output 
     GL_AMD_seamless_cubemap_per_texture 
     GL_EXT_shader_integer_mix 
     GL_NV_point_sprite 
     GL_ARB_sync 
     GL_ARB_multisample 
     GL_ARB_compatibility 
     GL_ARB_separate_shader_objects 
     GL_ARB_query_buffer_object 
     GL_EXT_shadow_funcs 
     GL_EXT_rescale_normal 
     GL_ARB_multitexture 
     GL_ARB_viewport_array 
     GL_ARB_explicit_attrib_location 
     GL_NV_vertex_buffer_unified_memory 
     GL_EXT_texture_sRGB_decode 
     GL_EXT_texture_filter_anisotropic 
     GL_ARB_geometry_shader4 
     GL_EXT_framebuffer_multisample_blit_scaled 
     GL_KHR_blend_equation_advanced 
     GL_NV_gpu_program_fp64 
     GL_ARB_pixel_buffer_object 
     GL_NV_gpu_program4_1 
     GL_ARB_shader_precision 
     GL_ARB_texture_env_add 
     GL_ARB_program_interface_query 
     GL_EXT_draw_range_elements 
     GL_ARB_shader_storage_buffer_object 
     GL_NV_shader_buffer_load 
     GL_ARB_texture_rgb10_a2ui 
     GL_NV_depth_buffer_float 
     GL_ARB_provoking_vertex 
     GL_EXT_import_sync_object 
     GL_KTX_buffer_region 
     GL_EXT_texture_compression_latc 
     GL_ARB_robust_buffer_access_behavior 
     GL_EXT_texture_edge_clamp 
     GL_S3_s3tc 
     GL_EXT_vertex_array 
     GL_NV_depth_clamp 
     GL_ARB_framebuffer_object 
     GL_ARB_clear_texture 
     GL_NV_texture_rectangle_compressed 
     GL_NV_vertex_program 
     GL_ARB_uniform_buffer_object 
     GL_EXT_texture_storage 
     GL_KHR_robustness 
     GL_ARB_clip_control 
     GL_NV_pixel_data_range 
     GL_OVR_multiview2 
     GL_EXT_texture_lod 
     GL_ARB_texture_storage_multisample 
     GL_EXT_shader_image_load_store 
     GL_ARB_shader_texture_lod 
     GL_ARB_texture_view 
     GL_EXT_texture_array 
     GL_NV_gpu_program4 
     GL_NV_texture_shader2 
     GL_ARB_polygon_offset_clamp 
     GL_NV_fog_distance 
     GL_ARB_vertex_program 
     GL_EXT_direct_state_access 
     GL_NV_blend_square 
     GL_KHR_parallel_shader_compile 
     GL_ARB_texture_barrier 
     GL_NV_texture_barrier 
     GL_EXT_fog_coord 
     GL_ARB_vertex_buffer_object 
     GL_ARB_explicit_uniform_location 
     GL_ARB_multi_bind 
     GL_EXT_point_parameters 
     GL_NV_multisample_filter_hint 
     GL_ARB_texture_multisample 
     GL_ARB_internalformat_query 
     GL_NVX_conditional_render 
     GL_ARB_tessellation_shader 
     GL_ARB_stencil_texturing 
     GL_EXT_timer_query 
     GL_NV_conditional_render 
     GL_ARB_sparse_texture 
     GL_IBM_texture_mirrored_repeat 
     WGL_EXT_swap_control 
     GL_ARB_spirv_extensions 
     GL_ARB_draw_buffers_blend 
     GL_NV_fragment_program 
     GL_NV_vertex_array_range 
     GL_ARB_window_pos 
     GL_ARB_texture_gather 
     GL_EXT_blend_equation_separate 
     GL_ARB_transform_feedback2 
     GL_EXT_vertex_array_bgra 
     GL_EXT_texture_sRGB 
     GL_NV_half_float 
     GL_ARB_framebuffer_sRGB 
     GL_NV_path_rendering 
     GL_NV_register_combiners 
     GL_ARB_vertex_type_10f_11f_11f_rev 
     GL_ARB_internalformat_query2 
     GL_ARB_occlusion_query 
     GL_ARB_parallel_shader_compile 
     GL_ARB_transform_feedback_overflow_query 
     GL_ARB_seamless_cube_map 
     GL_ARB_shader_ballot 
     GL_EXT_transform_feedback2 
     GL_EXT_framebuffer_sRGB 
     GL_ARB_shadow 
     GL_ARB_shader_atomic_counters 
     GL_EXT_memory_object 
     GL_EXT_secondary_color 
     GL_EXT_framebuffer_blit 
     GL_NV_compute_program5 
     GL_ATI_texture_float 
     GL_ARB_fragment_program_shadow 
     GL_NV_query_resource_tag 
     GL_EXT_semaphore 
     GL_ARB_texture_float 
     GL_ARB_gl_spirv 
     GL_NV_shader_thread_shuffle 
     GL_NV_texture_compression_vtc 
     GL_ARB_texture_storage 
     GL_EXT_blend_minmax 
     GL_KHR_no_error 
     GL_EXT_texture_integer 
     GL_EXT_texture_shared_exponent 
     GL_NV_shader_thread_group 
     GL_ARB_shader_objects 
     GL_EXT_stencil_two_side 
     GL_EXT_semaphore_win32 
     GL_EXT_bgra 
     GL_ARB_fragment_layer_viewport 
     GL_NV_texture_multisample 
     GL_NV_transform_feedback2 
     GL_ATI_draw_buffers 
     GL_EXT_blend_subtract 
     GL_ARB_shader_bit_encoding 
     GL_NV_copy_image 
     GL_EXT_texture_compression_rgtc 
     GL_NV_alpha_to_coverage_dither_control 
     GL_NV_vertex_program1_1 
     GL_EXT_provoking_vertex 
     GL_EXT_separate_shader_objects 
     GL_ARB_depth_clamp 
     GL_ARB_compute_shader 
     GL_ARB_shader_image_load_store 
     GL_ARB_texture_env_combine 
     GL_ARB_ES3_1_compatibility 
     GL_ARB_shader_subroutine 
     GL_NV_bindless_multi_draw_indirect 
     GL_EXT_packed_depth_stencil 
     GL_NV_texture_shader3 
     GL_EXT_gpu_shader4 
     GL_NV_gpu_program5 
     GL_ARB_copy_buffer 
     GL_ARB_sample_shading 
     GL_EXT_memory_object_win32 
     GL_KHR_debug 
     GL_EXT_multi_draw_arrays 
     GL_ARB_indirect_parameters 
     GL_NV_draw_vulkan_image 
     GL_NV_feature_query 
     GL_ARB_point_parameters 
     GL_EXT_window_rectangles 
     GL_NV_light_max_exponent 
     GL_ARB_texture_env_crossbar 
     GL_NV_shader_atomic_float 
     GL_ARB_robustness 
     GL_ARB_draw_elements_base_vertex 
     GL_NV_explicit_multisample 
     GL_ARB_framebuffer_no_attachments 
     GL_ARB_sampler_objects 
     GL_AMD_multi_draw_indirect 
     GL_ARB_derivative_control 
     GL_NV_draw_texture 
     GL_NV_texture_rectangle 
     GL_ARB_color_buffer_float 
     GL_NV_bindless_multi_draw_indirect_count 
     GL_ARB_base_instance 
     GL_EXT_texture_env_add 
     GL_ARB_texture_compression_bptc 
     GL_ARB_ES3_compatibility 

QPA OpenGL Detection Info 
  supportsDesktopGL: true 
  supportsAngleD3D11: true 
  isQtPreferAngle: true 
  Detected renderers: 
    (Supported) GeForce GTX 765M/PCIe/SSE2 (4.6.0 NVIDIA 425.31) 
    (Supported) ANGLE (Microsoft, Microsoft Basic Render Driver Direct3D11 vs_5_0 ps_5_0, D3D11-10.0.19041.3636) (OpenGL ES 3.0.0 (ANGLE 2.1.0 git hash: f2280c0c5f93+krita_qt5)) 
    (Supported) ANGLE (NVIDIA, NVIDIA GeForce GTX 765M Direct3D11 vs_5_0 ps_5_0, D3D11-25.21.14.2531) (OpenGL ES 3.0.0 (ANGLE 2.1.0 git hash: f2280c0c5f93+krita_qt5))  

useBufferInvalidation (config option): false


Hardware Information

  GPU Acceleration: desktop
  Memory: 32685 Mb
  Number of Cores: 8
  Swap Location: C:/Users/bontakun/AppData/Local/Temp
  Built for: sse2
  Base instruction set: fma3+avx2
  Supported instruction sets: fma3+avx2 avx2 fma3+avx avx fma4 fma3+sse4.2 sse4.2 sse4.1 ssse3 sse3 sse2 

Current Settings

  Current Swap Location: C:/Users/bontakun/AppData/Local/Temp
  Current Swap Location writable: true
  Undo Enabled: true
  Undo Stack Limit: 30
  Use OpenGL: true
  Use OpenGL Texture Buffer: true
  Disable Vector Optimizations: false
  Disable AVX Optimizations: false
  Canvas State: OPENGL_SUCCESS
  Autosave Interval: 900
  Use Backup Files: true
  Number of Backups Kept: 1
  Backup File Suffix: ~
  Backup Location: Same Folder as the File
  Backup Location writable: false
  Resource Location: C:/Users/bontakun/AppData/Roaming/krita
  Use Win8 Pointer Input: false
  Use RightMiddleTabletButton Workaround: false
  Levels of Detail Enabled: false
  Use Zip64: false


Loaded Python Plugins
	colorspace
	comics_project_management_tools
	documenttools
	exportlayers
	filtermanager
	lastdocumentsdocker
	plugin_importer
	quick_settings_docker
	scripter
	tenbrushes
	tenscripts


Display Information
Number of screens: 1
	Screen: 0
		Name: \\.\DISPLAY1
		Depth: 32
		Scale: 1
		Physical DPI141.585
		Logical DPI96
		Physical Size: 344, 194
		Position: 0, 0
		Resolution in pixels: 1920x1080
		Manufacturer: Chimei Innolux Corporation
		Model: CMN15b1
		Refresh Rate: 60
		Serial Number:
Comment 1 Sebastian Haas 2024-03-28 18:43:26 UTC
I don't knbow if it's relevant (I suspect not...), but I forgot to mention it, the Krita version I use, I installed/updated through Steam...
Comment 2 Emmet O'Neill 2024-09-17 22:24:53 UTC
*** Bug 486324 has been marked as a duplicate of this bug. ***
Comment 3 Emmet O'Neill 2024-10-10 21:32:11 UTC
Hey Sebastian, thanks for the report.

As of today I can't reproduce this bug on Linux master branch, so it's either already been fixed (possible by one of Dmitry's recent animation interface or trans mask patches) or I'm just not able to reproduce it on my system/platform. 

As such I'm going to close this bug for now under the "works for me" label. 
With that said, please try the nightly build or latest master branch source build, and feel free to reopen this bug if you're still experiencing it and we can continue form there.