Bug 484610 - Advanced search fails to find photos from Ricoh GR II when searching by 'Make'
Summary: Advanced search fails to find photos from Ricoh GR II when searching by 'Make'
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Advanced (show other bugs)
Version: 8.4.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-27 17:09 UTC by mahikeulbody
Modified: 2024-03-27 17:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.4.0
Sentry Crash Report:


Attachments
test file from Ricoh GR II (2.50 MB, image/jpeg)
2024-03-27 17:09 UTC, mahikeulbody
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mahikeulbody 2024-03-27 17:09:31 UTC
Created attachment 167854 [details]
test file from Ricoh GR II

Exif:Make of this device is "RICOH IMAGING COMPANY, LTD." (see attached file)
Metadata Exif right panel shows the right string.

But in the list of choice for 'Make' in Advanced Search, there is only "RICOH IMAGING, LTD.". So Digikam cannot find any Ricoh GR II photos when searching them via 'Make'.

By the way, the Photograph Properties right panel shows "RICOH IMAGING, LTD.", not "RICOH IMAGING COMPANY, LTD.".
Comment 1 Maik Qualmann 2024-03-27 17:46:06 UTC
In fact, we shorten some makes, here is the code:

https://invent.kde.org/graphics/digikam/-/blob/master/core/libs/properties/itempropertiestab_helpers.cpp?ref_type=heads#L96

In your case, a string within is removed, which means that it is no longer recognized in the database.

Maik
Comment 2 Maik Qualmann 2024-03-27 17:51:03 UTC
The company is actually always listed on the web as “Ricoh Imaging”. I would actually shorten it to that.

Maik
Comment 3 mahikeulbody 2024-03-27 17:54:53 UTC
I have no problem with shorten Make into Photograph Properties right panel ; I only would like to be able to search the photos from this device.
Comment 4 Maik Qualmann 2024-03-27 17:57:05 UTC
Git commit 4fb66a77947640fe9e45d84cdb39c626974ad2f4 by Maik Qualmann.
Committed on 27/03/2024 at 17:56.
Pushed by mqualmann into branch 'master'.

shortened make name to Ricoh Imaging
FIXED-IN: 8.4.0

M  +1    -1    NEWS
M  +1    -0    core/libs/properties/itempropertiestab_helpers.cpp

https://invent.kde.org/graphics/digikam/-/commit/4fb66a77947640fe9e45d84cdb39c626974ad2f4