Created attachment 167845 [details] UI Element SUMMARY The current name for the toolbar element to show and hide the sidebar is unnecessary long: Hide/Show the component sidebar This makes it uneasy, to use this as a dedicated button in the toolbar. (See screenshot) First, there is no other sidebar, so "component" is superfluous to begin with. Second, other buttons have the option to change, depending on the state. Like in Dolphin, where the "Split" element changes into "Close" and vice versa. We could implement, to do the same here. Otherwise, I suggest to rename the element simply into "Sidebar" and call it a day. Also consider, that this causes the translators to do work, so let us decide on this with foresight. :) Thanks a lot STEPS TO REPRODUCE 1. Open Kontact, switch to the KMail panel (I assume standalone Kmail is the same) 2. Add the 'Hide/Show the component sidebar' element to the toolbar. 3. Acknowledge, that it takes much space. Operating System: NixOS 24.05 KDE Plasma Version: 6.0.2 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Kernel Version: 6.6.22 (64-bit) Graphics Platform: Wayland Processors: 16 × AMD Ryzen 7 5800U with Radeon Graphics Memory: 13,5 GiB of RAM Graphics Processor: AMD Radeon Graphics
Git commit c544a50d4aed519ba170f4686612403254667dc2 by Laurent Montel. Committed on 27/03/2024 at 21:41. Pushed by mlaurent into branch 'master'. Fix bug 484599: Name of UI element too long (Hide/Show Sidebar) Rename it. FIXED-IN: 24.04.0 M +1 -1 src/mainwindow.cpp https://invent.kde.org/pim/kontact/-/commit/c544a50d4aed519ba170f4686612403254667dc2
Do I understand this right, that the text now says 'Show Sidebar' both when its already open, and when its closed?
Yep it's a checkable button. Same for "show toolbar"/"Full screen" etc.
So it will show 'Hide Sidebar' when open?
nope as for "show toolbar"/"Full screen" etc. we keep it and we have info from checked state.
I am just confused