Bug 484414 - highlight split panel borders when split view actived
Summary: highlight split panel borders when split view actived
Status: RESOLVED WORKSFORME
Alias: None
Product: dolphin
Classification: Applications
Component: split view (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-24 20:44 UTC by Cherkah
Modified: 2024-05-01 03:46 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
theme2 (364.60 KB, image/png)
2024-03-27 18:14 UTC, Cherkah
Details
theme (158.01 KB, image/png)
2024-03-27 18:15 UTC, Cherkah
Details
theme1 (508.88 KB, image/png)
2024-03-27 18:16 UTC, Cherkah
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cherkah 2024-03-24 20:44:21 UTC
SUMMARY

when using light theme and split view is activated it is painful to identified the one which is selected.
it is more boring when you have selected the feature "close the active panel when ..." in dolphin settings.

STEPS TO REPRODUCE
1. select a light theme
2. split view in dolphin
3. try to find what is the active panel 

OBSERVED RESULT
impossible to identify the active one

EXPECTED RESULT
highlight split panel border (the active one) when split view.
as in "selection mode" with colors

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Operating System: EndeavourOS 
KDE Plasma Version: 6.0.2
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.8.1-zen1-1-zen (64-bit)
Graphics Platform: Wayland

ADDITIONAL INFORMATION
Comment 1 Felix Ernst 2024-03-27 15:18:43 UTC
>OBSERVED RESULT
>impossible to identify the active one

Are you sure? While it is true that we no longer show a bright blue border around the active view, we made sure that the background colour between the active and inactive view are wildly different. I actually find it way easier to identify which side is active because of this change. Previously the blue border was also shown for whichever view I hovered the mouse cursor over so both of the views had blue border which actually made it very difficult for me to guess which one is active.

If there really is no difference for you between the two, there might be a bug elsewhere. Perhaps you are using a theme that doesn't has the same colour set for two roles which really should have distinct colours.
Comment 2 Cherkah 2024-03-27 18:14:48 UTC
Created attachment 167856 [details]
theme2
Comment 3 Cherkah 2024-03-27 18:15:24 UTC
Created attachment 167857 [details]
theme
Comment 4 Cherkah 2024-03-27 18:16:20 UTC
Created attachment 167858 [details]
theme1
Comment 5 Cherkah 2024-03-27 18:24:02 UTC
> Are you sure? ... If there really is no difference for you between the two

see the pictures 

>  there might be a bug elsewhere. 

that's why i'm filling a bug.


as i said, even  with black theme the issue is the same. Hope it will remove with the plasma 6.0.3 update ?!!!
Comment 6 Felix Ernst 2024-03-29 11:19:46 UTC
(In reply to Cherkah from comment #5)
> > Are you sure? ... If there really is no difference for you between the two
> 
> see the pictures

Indeed no difference. However, from the picture it is clear that Dolphin is definitely not using the default Breeze style. For example: In actual default Breeze the separator between the two views is only a 1 pixel thick line. See this picture for comparison: https://invent.kde.org/system/dolphin/uploads/2e616d5cfbf5297fa4d42781dc6df2c7/Screenshot_2024-03-26_002239.png

Be aware that there is a difference between the Global Theme, the application style and the Plasma style, so even though your pictures show that you are using a Breeze global theme and a Breeze Plasma style, the application still seems to use a non-Breeze style for some reason.

Since this bug seems to only happen with a third-party theme that is not part of KDE, it is somewhat likely that we can't fix this on our side. Please file a bug report for the third-party theme that you are using. They might be able to resolve this when we can't.
Comment 7 Cherkah 2024-03-29 15:59:11 UTC
>  See this picture for comparison

even on your example i cannot distinguish which side is selected. If any was unselected, you should have to chose a splitting side so as to show better the effect of nuance/colour.

> Since this bug seems to only happen with a third-party theme that is not part of KDE, it is somewhat likely that we can't fix this on our side.

what i've asked to your team it is an solution "no theme dependent".  At the end of the day, what you are saying it is "people must use theme which respect/have the same color set for two roles". 
But may i use on KDE plasma6 "ANY theme/third-party theme" that i want/need and in same time do not lost some graphical features ?
Comment 8 Felix Ernst 2024-03-30 15:33:52 UTC
(In reply to Cherkah from comment #7)
> But may i use on KDE plasma6 "ANY theme/third-party theme" that i want/need
> and in same time do not lost some graphical features ?

No, that is literally impossible. You are allowed to use any theme, including themes which use the same colour for everything.
Comment 9 Cherkah 2024-03-30 15:46:32 UTC
ok 
and thus what do you think about a "no theme dependent" solution, like a thine color frame or anything else that can be really relevant and effective for this issue?
Comment 10 Felix Ernst 2024-03-31 14:35:01 UTC
A colour frame is typically also drawn by the theme. For example the colour frame that was used in Dolphin previously was also drawn by the Breeze theme. If we were to draw a colour frame regardless of the theme we might be working against the artistic goals the theme author tried to accomplish.

I really think we shouldn't put it on ourselves to overwrite the visuals a theme provides. The theme itself should play by common rules, so it works nicely with our software.

Of course this doesn't mean that it is always the theme author's fault if an application looks wrong. Maybe we wrote software in a way that themes can't really be expected to adapt to. I have no reason to think this is the reason in this case though.
Comment 11 Cherkah 2024-03-31 15:13:17 UTC
Ok the debate is close, if indeed there was one !

But when i include :
> ... or anything else ...
i was giving the " choice " to find a distinctive solution  which takes into consideration your internal rules / graphic charter and others.

For example a small distinctive sign (point, dash, line, etc.) could have been considered without coming into conflict with the color frame policy already managed by the active theme.
Or anything else ... It's up to you

As kde plasma user, my duty was only to report relevant free software bugs/weak points  whose perfection is still in progress.

regards
Comment 12 Felix Ernst 2024-04-01 14:47:54 UTC
(In reply to Cherkah from comment #11)
> Ok the debate is close, if indeed there was one !

> i was giving the " choice " to find a distinctive solution  which takes into
> consideration your internal rules / graphic charter and others.
> 
> For example a small distinctive sign (point, dash, line, etc.) could have
> been considered without coming into conflict with the color frame policy
> already managed by the active theme.

Yea, well I unfortunately don't see a way for us to improve this which wouldn't in turn lead to more problems elsewhere. 

> Or anything else ... It's up to you

Maybe others have a different view on this or better ideas that wouldn't lead to problems elsewhere.

> As kde plasma user, my duty was only to report relevant free software
> bugs/weak points  whose perfection is still in progress.

Thanks for that!

>regards

regards
Comment 13 Cherkah 2024-04-01 15:36:35 UTC
Please try to submit/push this idea to your kde community developer or to a vote by end users.
Perhaps in the relatively near future this function will be considered as necessary.

this will 100% complete the design of "split view" feature.

regards
Comment 14 Bug Janitor Service 2024-04-16 03:52:33 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 15 Bug Janitor Service 2024-05-01 03:46:04 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!