Bug 484279 - background color used in settings leads to bad contrast
Summary: background color used in settings leads to bad contrast
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 6.1.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-22 21:19 UTC by William
Modified: 2024-12-17 18:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
picture of discover settings (4.06 KB, image/png)
2024-03-22 21:19 UTC, William
Details
color-scheme (3.38 KB, text/plain)
2024-03-22 21:20 UTC, William
Details

Note You need to log in before you can comment on or make changes to this bug.
Description William 2024-03-22 21:19:45 UTC
Created attachment 167624 [details]
picture of discover settings

SUMMARY
The Settings page in Discover uses a new background color for the row, which is generated from the color-schemes [Colors:Window] -> BackgroundNormal
value, this however does not work properly for very dark themes, e.g. pure black window color leads to white text on almost white background.


STEPS TO REPRODUCE
1. Use color-scheme Breeze-Dark
2. Change Window-background color to pure-black #000000
3. Open Discover Settings

OBSERVED RESULT
Settings almost unreadable, background color is almost white.


EXPECTED RESULT
The colors from my color-scheme should not be "manipulated" and the background should just be black.


SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.0.2
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Comment 1 William 2024-03-22 21:20:42 UTC
Created attachment 167625 [details]
color-scheme
Comment 2 William 2024-03-22 21:26:29 UTC
Added color-scheme (default breeze-dark with only one color changed to black). Why does a white-greyish color (#BEBEBE) when changing a color to black.
It is impossible to change this color without also changing the window-background of lets say the calculator app, Maybe there should be an option to set this color specifically in the color-scheme (where #BEBEBE wich is 190,190,190 in dez) is never even present.

Anyways somehow the behind-the-options stuff that generates this color is not working properly for dark colors.
Comment 3 Harald Sitter 2024-04-05 03:23:15 UTC
These are standard SwipeListItem delegates apparently. Moving to Kirigami.
Comment 4 William 2024-04-26 17:32:53 UTC
bump: discover settings page is the only thing that seems to be affected. is the SwipeListItem not used anywhere else?

And why cant discover set the normal default background overwritting whatever kirigami sets as the standard?
Comment 5 Aleix Pol 2024-04-27 16:01:47 UTC
Why would Discover override something that is not specific to Discover?

This is the relevant code in Discover:
https://invent.kde.org/frameworks/kirigami/-/blob/master/src/controls/SwipeListItem.qml?ref_type=heads#L150

Maybe we shouldn't be using the highlighted text without a highlighted background I guess.
Comment 6 William 2024-04-27 18:05:43 UTC
because the current background color comes from out of nowhere and cannot be configured in kde color-scheme settings. thats bad, but if a fix in Kirigami takes more effort/ time why not do what was done in qt5 and use the normal background color that is used everywhere else and can be configured?

the color looks out of place in any color scheme even breeze default and is nowhere to be found in the color-scheme file.
Comment 7 William 2024-06-29 16:43:12 UTC
bump: still a problem in plasma 6.1: breaking all dark color-schemes
Comment 8 William 2024-10-09 15:51:02 UTC
plasma 6.2: discover settings still not readable for any dark color-scheme
Comment 9 William 2024-12-17 18:43:28 UTC
plasma 6.2.4 the issue is resolved and background color in settings is as expected