Bug 484026 - Folder View on Panel does not follow Double Click setting
Summary: Folder View on Panel does not follow Double Click setting
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop Containment (show other bugs)
Version: 6.0.2
Platform: openSUSE Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2024-03-19 22:32 UTC by ryu.ketsueki
Modified: 2024-06-21 16:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ryu.ketsueki 2024-03-19 22:32:52 UTC
SUMMARY
I believe this must be a regression from 5.27, as this issue did not exist prior to my update to 6.0.2. I added a Folder View to a panel and set it as Downloads Folder View. The items on the list open with single click as opposed to double click. This also makes the option "Rename inline by clicking selecting item's text" option on Folder View settings unusable, as it will prioritize click to open.

Operating System: openSUSE MicroOS 20240317
KDE Plasma Version: 6.0.2
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.7.9-1-default (64-bit)
Graphics Platform: Wayland
Processors: 4 × Intel® Core™ i3-7020U CPU @ 2.30GHz
Memory: 11.5 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 620

ADDITIONAL INFO
KDE Plasma 6 coming from the OpenSUSE Repos instead of KDE Repos, so they passed their openQA.
Comment 1 Nate Graham 2024-04-11 03:02:41 UTC
That's right, it doesn't; I'm afraid this is intentional for the list view mode because it behaves less like a file view and more like a menu, and those are always single-click. However you're right that renaming inline doesn't work in this case but it's a general issue affecting all of Folder View items when in single-click mode. It's for that reason that the "rename inline" checkbox to enable and disable the feature isn't shown here.
Comment 2 ryu.ketsueki 2024-04-11 10:24:58 UTC
I'll have to be honest, this is strange. So far I have been using Foldier View in List View on the panel as a quick way of accessing my Downloads folder, much like it is possible on Mac OS. So I move things out of the list view to another folder on Dolphin like this but it is frustrating how I have to use the select icon on the left before I do that. It would have been better to at least have the option to enable double click on the list view again.
Comment 3 Nate Graham 2024-04-11 16:23:15 UTC
Thinking about it myself, there are competing design goals here:

1. These are files or folders so they should follow the "clicking on files or folders" setting
2. They're displayed in a pop-up menu so the list items should behave like a normal menu which is always single-click

VDG folks, thoughts?
Comment 4 ryu.ketsueki 2024-04-11 19:05:56 UTC
(In reply to Nate Graham from comment #3)
> Thinking about it myself, there are competing design goals here:
> 
> 1. These are files or folders so they should follow the "clicking on files
> or folders" setting
> 2. They're displayed in a pop-up menu so the list items should behave like a
> normal menu which is always single-click
> 
> VDG folks, thoughts?

Adding to that, I switched away from List View to Icon View and see if I could adapt to that mode instead but it still does not follow the "Clicking on files or folders" setting. It still opens with single click
Comment 5 Nate Graham 2024-04-11 20:51:39 UTC
But only on a panel. Though in that case, yeah, the whole "its actually a menu" logic starts to break down.
Comment 6 Nate Graham 2024-06-21 16:52:52 UTC
Git commit b7c80c6419b4eb3ae4b1024acf88da13d92e6b29 by Nate Graham.
Committed on 21/06/2024 at 16:45.
Pushed by ngraham into branch 'master'.

Revert "Folder View: with menu representation, always open with a single click"

This reverts commit d5abf12d6661f2a8f8449d9abe88468114a73dca.

The change to always open items in single-click when using list mode
was added by me in
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1467 with
two +1s and no discussion. But in retrospect, I think it was not the
right change; the list-view popup may look like a menu and kind of acts
like a menu, but it's not a menu--it's a file view in list mode. We
don't force single-click for other such views in Dolphin, file dialogs,
Kate, or other place where there are file views.
Related: bug 420261
FIXED-IN: 6.2

M  +1    -2    containments/desktop/package/contents/ui/FolderItemDelegate.qml
M  +3    -2    containments/desktop/package/contents/ui/FolderView.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/b7c80c6419b4eb3ae4b1024acf88da13d92e6b29