Bug 483905 - Can't generate icons on Windows
Summary: Can't generate icons on Windows
Status: REPORTED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: master
Platform: Compiled Sources Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-18 15:03 UTC by Dan Keenan
Modified: 2024-03-18 15:03 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Keenan 2024-03-18 15:03:41 UTC 
SUMMARY
I noticed that generating icons (i.e. dark variants) is expressly disabled on Windows as of commit 6324f834 from 3 years ago. Is there any backstory or previous efforts in fixing this? My searches didn't turn anything up and I'd love to know if there have been previous attempts before diving into it myself.


STEPS TO REPRODUCE
1. Try to cmake configure the project, even with Python and lxml installed.
2. cmake --build

OBSERVED RESULT
Generating icons is always disabled with an admonition to ensure Python and lxml are always installed (as if they weren't). This means that, with very few exceptions, dark icons are identical to light icons when built on Windows.

EXPECTED RESULT
Dark icons generated properly.

SOFTWARE/OS VERSIONS
Windows: Windows 11 Home 23H2
macOS: Not tested
Linux/KDE Plasma: Not tested
(available in About System)
KDE Plasma Version: Not tested
KDE Frameworks Version: Not tested
Qt Version: Qt 6.6
breeze-icons commit 98c004456cf3ba9aa46b201a916c9e6b0e31f1a2

ADDITIONAL INFORMATION
https://invent.kde.org/frameworks/breeze-icons/-/commit/6324f834e991ace73a07503877420c7ec44e49c1