STEPS TO REPRODUCE Press Meta + G to open the grid and keep holding down both keys OBSERVED RESULT The effect opens and closes manically. EXPECTED RESULT The effect only opens once. SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20240314 KDE Plasma Version: 6.0.2 KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 Kernel Version: 6.7.9-1-default (64-bit) Graphics Platform: Wayland
I can reproduce it.
Currently shortcuts trigger on press, and will re-trigger upon key autorepeat. If we don't plan on changing that, this should be closed as resolved-intentional. Note that for other shortcuts (like ctrl-V), users would probably expect this behavior. So IMO this is intentional.
(In reply to fanzhuyifan from comment #2) > Note that for other shortcuts (like ctrl-V), users would probably expect > this behavior. So IMO this is intentional. IMO there should be two types of hot-keys, those that re-trigger (Ctrl+V, Ctrl+R/Z, ...) and those that don't (Meta+G, Meta+O,Meta+C, Meta+Tab*). Having the mentioned effects for instance auto-re-trigger seems just wrong. Kickoff for instance doesn't open/close repeatedly when holding down Meta. For Meta+Tab it could make sense, but the speed with it switches between windows is way too fast to be usable.
Modifier only shortcuts are handled differently and are triggered on release since it doesn't make sense to trigger them on press. The repeat speed is controlled by key repeat settings. If we support two types of shortcuts, we have to think about whether we expose that to the users. Not exposing that might make things confusing, where some shortcuts trigger on repeat and some don't, while exposing the setting might make things too complicated.
(In reply to fanzhuyifan from comment #2) > Currently shortcuts trigger on press, and will re-trigger upon key > autorepeat. If we don't plan on changing that, this should be closed as > resolved-intentional. > > Note that for other shortcuts (like ctrl-V), users would probably expect > this behavior. So IMO this is intentional. Yes, that's intentional.
> Yes, that's intentional. But what about > IMO there should be two types of hot-keys, those that re-trigger (Ctrl+V, Ctrl+R/Z, ...) and those that don't (Meta+G, Meta+O,Meta+C, Meta+Tab*). May I open another more general issue for it? I mean it doesn't need to be resolved immediately but it could be on the radar and implemented later ...
(In reply to postix from comment #6) > May I open another more general issue for it? I mean it doesn't need to be > resolved immediately but it could be on the radar and implemented later ... This introduces inconsistencies in how shortcuts are handled, complicates the UX, and adds more code complexity for little benefit.
> complicates the UX, and adds more code complexity for little benefit. Maybe not too little benefit: One legit reason which came into my mind is that it could be an issue for people with epilepsy [1]: > Content that flickers, flashes, or blinks can trigger photosensitive epilepsy. The rapid opening/closing is definitely kind of a flickering/flashing effect, though I don't have any experience with it myself nor do I know people who may be affected to absolutely proof it. But if it is, it should maybe be avoided at any cost? [1] https://developer.mozilla.org/en-US/docs/Web/Accessibility/Seizure_disorders