Bug 483529 - System Sensor Widget in Panel uses wrong size with columns in grid view
Summary: System Sensor Widget in Panel uses wrong size with columns in grid view
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Monitor (show other bugs)
Version: 6.0.2
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression
Depends on:
Blocks:
 
Reported: 2024-03-14 10:00 UTC by produnis
Modified: 2024-04-19 06:41 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.5


Attachments
how it should look (27.07 KB, image/webp)
2024-03-14 10:00 UTC, produnis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description produnis 2024-03-14 10:00:52 UTC
Created attachment 167158 [details]
how it should look

STEPS TO REPRODUCE
1. Set up a Panel at the left side of your screen, 100px width
2. place the system sensor widget into that panel
3. pick 4 random sensors
4. choose "grid" with 2 columns

OBSERVED RESULT
Only 2 cells are viewable, the other 2 cells are hidden

This is how it actually looks:
https://i.imgur.com/PUIbAx4.png


EXPECTED RESULT
Show all columns in panel,
this is how it should look like (and did in plasma5): https://i.imgur.com/nWBjREA.jpeg

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:  archlinux, wayland
KDE Plasma Version:  6.0.2
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Comment 1 Nate Graham 2024-04-09 22:09:47 UTC
Can confirm.
Comment 2 Bug Janitor Service 2024-04-15 12:04:59 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/339
Comment 3 Akseli Lahtinen 2024-04-18 08:55:09 UTC
Git commit bd3173507ae2554863226aac7a25f1ffebe362d1 by Akseli Lahtinen.
Committed on 18/04/2024 at 08:55.
Pushed by akselmo into branch 'master'.

Fix linecharts and bar charts for small sizes

In small sizes, linecharts still tried to show both the y-axis legend and grid lines.
Bar charts did not resize the bar properly.

For linechart this hides both when the size is too small to fit them properly.

M  +3    -1    faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
M  +1    -1    faces/facepackages/facegrid/contents/ui/CompactRepresentation.qml
M  +8    -2    faces/facepackages/facegrid/contents/ui/FaceControl.qml
M  +2    -1    faces/facepackages/facegrid/contents/ui/FaceGrid.qml
M  +1    -1    faces/facepackages/facegrid/contents/ui/FullRepresentation.qml
M  +2    -0    faces/facepackages/linechart/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/libksysguard/-/commit/bd3173507ae2554863226aac7a25f1ffebe362d1
Comment 4 Akseli Lahtinen 2024-04-18 08:58:33 UTC
Git commit ff7d5fd6bb37d772a8bdf736deba87204ffe1325 by Akseli Lahtinen.
Committed on 18/04/2024 at 08:56.
Pushed by akselmo into branch 'Plasma/6.0'.

Fix linecharts and bar charts for small sizes

In small sizes, linecharts still tried to show both the y-axis legend and grid lines.
Bar charts did not resize the bar properly.

For linechart this hides both when the size is too small to fit them properly.


(cherry picked from commit bd3173507ae2554863226aac7a25f1ffebe362d1)

d888ad4c Set compact to grid and control from representations
d6ca9bee Fix linechart sizes
c0b51a4b Fix styling
95e965fa Fix bar chart compact rep

M  +3    -1    faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
M  +1    -1    faces/facepackages/facegrid/contents/ui/CompactRepresentation.qml
M  +8    -2    faces/facepackages/facegrid/contents/ui/FaceControl.qml
M  +2    -1    faces/facepackages/facegrid/contents/ui/FaceGrid.qml
M  +1    -1    faces/facepackages/facegrid/contents/ui/FullRepresentation.qml
M  +2    -0    faces/facepackages/linechart/contents/ui/CompactRepresentation.qml

https://invent.kde.org/plasma/libksysguard/-/commit/ff7d5fd6bb37d772a8bdf736deba87204ffe1325