Bug 483375 - Symbolic icon color on Sticky Note should change based on note color
Summary: Symbolic icon color on Sticky Note should change based on note color
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: notes (show other bugs)
Version: 6.0.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-03-12 20:32 UTC by Christopher Smith
Modified: 2024-06-07 20:11 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/libplasma/-/commit/42322d729a37a4373586c311e330b5dde3196720
Version Fixed In: 6.1
Sentry Crash Report:

Attachments
Light Mode, default note color (67.48 KB, image/png)
2024-03-12 20:34 UTC, Christopher Smith 		Details
Dark Mode, default note color (68.73 KB, image/png)
2024-03-12 20:35 UTC, Christopher Smith 		Details
Dark Mode, white note color (68.41 KB, image/png)
2024-03-12 20:35 UTC, Christopher Smith 		Details
Dark Mode, black note color (70.45 KB, image/png)
2024-03-12 20:35 UTC, Christopher Smith 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Smith 2024-03-12 20:32:35 UTC 
SUMMARY
The symbolic icons on the Sticky Note widget currently only switches color when the theme is set to light or dark mode. Changing the note color doesn't cause any change. This causes the icons to be significantly less visible when they are as dark as the color of the note. The behavior should be swapped in order to make the icons more legible.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 6.0
KDE Plasma Version: 6.0.0
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Comment 1 Christopher Smith 2024-03-12 20:34:40 UTC 
Created attachment 167060 [details]
Light Mode, default note color
Comment 2 Christopher Smith 2024-03-12 20:35:08 UTC 
Created attachment 167061 [details]
Dark Mode, default note color
Comment 3 Christopher Smith 2024-03-12 20:35:28 UTC 
Created attachment 167062 [details]
Dark Mode, white note color
Comment 4 Christopher Smith 2024-03-12 20:35:48 UTC 
Created attachment 167063 [details]
Dark Mode, black note color
Comment 5 Nate Graham 2024-03-13 22:06:25 UTC 

*** This bug has been marked as a duplicate of bug 477008 ***
Comment 6 Nate Graham 2024-06-07 20:11:32 UTC 
Git commit 442586f84d6f736ad88b82182d92e0ca007eaab1 by Nate Graham, on behalf of Evgeniy Harchenko.
Committed on 07/06/2024 at 20:11.
Pushed by ngraham into branch 'master'.

private/ButtonContent: Make buttons' icon colors settable externally

Some applets, e.g. Notes, needed the possibility to set color for
button's icons. But we cant' do that because color property is not
used at all in all buttons which use `ButtonContent` as `contentItem`.
FIXED-IN: 6.1

M  +1    -0    src/declarativeimports/plasmacomponents3/private/ButtonContent.qml

https://invent.kde.org/plasma/libplasma/-/commit/442586f84d6f736ad88b82182d92e0ca007eaab1
Comment 7 Nate Graham 2024-06-07 20:11:52 UTC 
Git commit 42322d729a37a4373586c311e330b5dde3196720 by Nate Graham.
Committed on 07/06/2024 at 20:11.
Pushed by ngraham into branch 'Plasma/6.1'.

private/ButtonContent: Make buttons' icon colors settable externally

Some applets, e.g. Notes, needed the possibility to set color for
button's icons. But we cant' do that because color property is not
used at all in all buttons which use `ButtonContent` as `contentItem`.
FIXED-IN: 6.1


(cherry picked from commit 442586f84d6f736ad88b82182d92e0ca007eaab1)

fa3e748c Made buttons' from PlasmaComponents color settable

Co-authored-by: Evgeniy Harchenko <evgeniyharchenko.dev@gmail.com>

M  +1    -0    src/declarativeimports/plasmacomponents3/private/ButtonContent.qml

https://invent.kde.org/plasma/libplasma/-/commit/42322d729a37a4373586c311e330b5dde3196720