Bug 483346 - hitboxes position on panel wont updated when transiting from floating panel to normal panel on x11
Summary: hitboxes position on panel wont updated when transiting from floating panel t...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: 6.0.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-03-12 14:45 UTC by Dandraghas
Modified: 2024-07-05 12:16 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
as you can see hitboxes for "icons only task manager" is stuck in a same position even after panel transitioned (3.27 MB, video/mp4)
2024-03-12 14:48 UTC, Dandraghas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dandraghas 2024-03-12 14:45:00 UTC
SUMMARY
When transitioned from floating panel to a normal panel, like opening a full-sized app, hitboxes for buttons wont be updated

removing panel and then creating new fixes that, but after reboot/logout issue is returning back

no problem like this on wayland

STEPS TO REPRODUCE
1. Start x11 session
2. Create a new floating panel
3. log out
4. Start x11 session again

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.0.1
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.7.9-zen1-1-zen (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i3-10100F CPU @ 3.60GHz
Memory: 15.5 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2
Manufacturer: ASUS

ADDITIONAL INFORMATION
This created in logs when i try to point mouse over a hitbox:
Mar 12 16:27:57 archlinux plasmashell[1731]: kf.plasma.quick: Exposed with no visual parent. Window positioning broken.
Mar 12 16:27:57 archlinux plasmashell[1731]: kf.plasma.quick: Exposed with no visual parent. Window positioning broken.
Mar 12 16:27:59 archlinux plasmashell[1731]: kf.plasma.quick: Exposed with no visual parent. Window positioning broken.
Mar 12 16:27:59 archlinux plasmashell[1731]: kf.plasma.quick: Exposed with no visual parent. Window positioning broken.

Also after transitioning from floating panel to normal panel extreme lag starting to happen, that only can be fixed by rebooting/logout
Comment 1 Dandraghas 2024-03-12 14:48:21 UTC
Created attachment 167039 [details]
as you can see hitboxes for "icons only task manager" is stuck in a same position even after panel transitioned
Comment 2 Niccolò Venerandi 2024-03-18 13:28:40 UTC
Mhh, no, this shouldn't happen regardless of the floatingness status of the panel, it's not a hitboxes issue. The panel should always be clickable on the screen edge, even if floating.
Comment 3 Marco Martin 2024-07-05 12:16:49 UTC
Git commit f7ee03d065b4e293746248f749a7965c4321b1cb by Marco Martin.
Committed on 05/07/2024 at 12:16.
Pushed by mart into branch 'master'.

Refactor floating panels

* Floating panels are always big enough to fit the floating version
* they never move during animations
* when they unfloat the masks get updated so that the extra area is completely hidden
* the exclusive zone never changes and follows the unfloated geometry
* maximize window animations are better, won't resize the window twice anymore
* unfloating animation is smoother now

depends from https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2309,
https://invent.kde.org/frameworks/ksvg/-/merge_requests/50,
https://invent.kde.org/plasma/libplasma/-/merge_requests/1166
and https://invent.kde.org/plasma/libplasma/-/merge_requests/1148
Related: bug 485648, bug 480550

M  +1    -0    shell/autotests/CMakeLists.txt
M  +19   -9    shell/panelshadows.cpp
M  +2    -1    shell/panelshadows_p.h
M  +81   -45   shell/panelview.cpp
M  +0    -1    shell/panelview.h

https://invent.kde.org/plasma/plasma-workspace/-/commit/f7ee03d065b4e293746248f749a7965c4321b1cb