Bug 483298 - Patch to update holiday_sg_en-gb to the year 2024-2026
Summary: Patch to update holiday_sg_en-gb to the year 2024-2026
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kholidays
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 6.0.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-11 22:34 UTC by Will Ng
Modified: 2024-03-15 16:54 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Updated holiday_sg_en-gb for 2024-2026 (2.15 KB, text/plain)
2024-03-11 22:34 UTC, Will Ng
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Will Ng 2024-03-11 22:34:03 UTC
Created attachment 166992 [details]
Updated holiday_sg_en-gb for 2024-2026

Holiday file for SG has not been updated since 2012.

I have attached an up-to-date version of public holidays, school holidays and observances for years 2024-2026 that can be merged.

Please note: (est) - estimated, as certain religious holidays do not exactly follow their respective religious calendars (maybe one day later/earlier), hence the actual date may not be able to be computed as of current time
Comment 1 Bug Janitor Service 2024-03-12 00:32:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kholidays/-/merge_requests/84
Comment 2 Will Ng 2024-03-12 15:40:03 UTC
(In reply to Bug Janitor Service from comment #1)
> A possibly relevant merge request was started @
> https://invent.kde.org/frameworks/kholidays/-/merge_requests/84

I have neglected to add one more source:
https://www.moe.gov.sg/news/press-releases/20230807-school-terms-and-holidays-for-2024

Please append on my behalf, thanks.

And yes, I am a SG native.
Comment 3 Jin Liu 2024-03-12 23:22:09 UTC
Added. Thanks.
Comment 4 Will Ng 2024-03-13 12:29:37 UTC
(In reply to Jin Liu from comment #3)
> Added. Thanks.

Hi, I noticed the newest commit is missing these lines that should go after Line 57:

"Hari Raya Haji"                 public religious on june 17 2024
"Hari Raya Haji (est)"           public religious on hijri thualhijjah 10

Please append, thanks!
Comment 5 Jin Liu 2024-03-13 12:37:21 UTC
Done.
Comment 6 Will Ng 2024-03-14 02:10:24 UTC
(In reply to Jin Liu from comment #5)
> Done.

Hi, have the lines been added? It doesn't seem to be part of any of the commits and changes in the merge request.
Comment 7 Jin Liu 2024-03-14 02:13:49 UTC
(In reply to Will Ng from comment #6)
> Hi, have the lines been added? It doesn't seem to be part of any of the
> commits and changes in the merge request.

Ah sorry, forgot to push to the server. Fixed now.
Comment 8 Allen Winter 2024-03-15 16:54:01 UTC
Git commit 44919a1cdf0155d98a15137a16f8930eb10a76f4 by Allen Winter, on behalf of Jin Liu.
Committed on 15/03/2024 at 16:53.
Pushed by winterz into branch 'master'.

Update holiday-sg

This update is provided (supposely by a Singapore native) in
https://bugs.kde.org/show_bug.cgi?id=483298

I haven't (can't) check if it is authentic.

M  +32   -0    holidays/plan2/holiday_sg_en-gb

https://invent.kde.org/frameworks/kholidays/-/commit/44919a1cdf0155d98a15137a16f8930eb10a76f4