Bug 483070 - Threshold for showing any text is too high in Plasma 6
Summary: Threshold for showing any text is too high in Plasma 6
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 6.0.1
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 447561 483826 484283 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-03-10 04:56 UTC by oldherl
Modified: 2024-04-29 14:43 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.4


Attachments
taskbar with labels hidden (2.67 KB, image/png)
2024-03-10 04:56 UTC, oldherl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description oldherl 2024-03-10 04:56:43 UTC
Created attachment 166842 [details]
taskbar with labels hidden

SUMMARY
When there are a lot of windows, the label (window title) is hidden when the room for it is small.
However, the current threshold for hiding the labels is too high for me. I would like an option to lower that threshold.
Currently it is hardcoded in  taskmanager/package/contents/ui/code/layout.js:

// Returns the number of 'm' characters whose joint width must be available in the task button label
// so that the button text is rendered at all.
function minimumMColumns() {
    return tasks.vertical ? 4 : 5;
}

I would like it configurable to as low as 1.

STEPS TO REPRODUCE
1. Open many windows
2. Watch the task manager.
3. 

OBSERVED RESULT
Labels are hidden despite there are still some space left, as the screenshot shows.

EXPECTED RESULT
Provide an option to display the label as long as one character can fit in.
This is especially useful when I have a lot of windows with names distinguishable at the first or second character, such as terminals or (dolphin) folders. 

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-04-10 20:32:45 UTC
*** Bug 483826 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2024-04-10 20:33:40 UTC
*** Bug 484283 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2024-04-10 20:58:25 UTC
I see the problem here; it's unintentional fallout from porting from PlasmaCore units to Kirigami Units. Let's see if I can fix it.
Comment 4 Bug Janitor Service 2024-04-10 21:33:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2188
Comment 5 Nate Graham 2024-04-12 20:06:41 UTC
Git commit 8608d7034199e9d19f3af3837d4b2f6baa8c8f4c by Nate Graham.
Committed on 12/04/2024 at 19:50.
Pushed by ngraham into branch 'master'.

applets/taskmanager: show text more often for traditional Task Manager

The minimum area for text was using a PlasmaCore unit that got ported to
Kirigami.Units.iconSizes.sizeForLabels for Plasma 6. This has different
semantics, resulting in the minimum size to show text increasing hugely.
As a result many people stopped seeing text in their task managers with
medium-thickness vertical panels crowded horizontal panels.

The more semantically correct iunit to port to is GridUnit. It's not
perfect though since it's the font height, not width. But it's the best
we've got.

In my testing, 1.5 of them  works perfectly for both vertical and
horizontal panels to only show text when there's at least one character
that won't be elided. This isn't a lot of text, but pepole use a
traditional Task Manager because they want to see text, so it at least
better matches their expectation than the status quo.
FIXED-IN: 6.0.4

M  +1    -1    applets/taskmanager/package/contents/ui/Task.qml
M  +5    -4    applets/taskmanager/package/contents/ui/code/layout.js

https://invent.kde.org/plasma/plasma-desktop/-/commit/8608d7034199e9d19f3af3837d4b2f6baa8c8f4c
Comment 6 Nate Graham 2024-04-12 20:18:20 UTC
Git commit 36cda2975a1e1d7771c7ea7aae73b0ebd089d5bc by Nate Graham.
Committed on 12/04/2024 at 20:12.
Pushed by ngraham into branch 'Plasma/6.0'.

applets/taskmanager: show text more often for traditional Task Manager

The minimum area for text was using a PlasmaCore unit that got ported to
Kirigami.Units.iconSizes.sizeForLabels for Plasma 6. This has different
semantics, resulting in the minimum size to show text increasing hugely.
As a result many people stopped seeing text in their task managers with
medium-thickness vertical panels crowded horizontal panels.

The more semantically correct iunit to port to is GridUnit. It's not
perfect though since it's the font height, not width. But it's the best
we've got.

In my testing, 1.5 of them  works perfectly for both vertical and
horizontal panels to only show text when there's at least one character
that won't be elided. This isn't a lot of text, but pepole use a
traditional Task Manager because they want to see text, so it at least
better matches their expectation than the status quo.
FIXED-IN: 6.0.4


(cherry picked from commit 8608d7034199e9d19f3af3837d4b2f6baa8c8f4c)

M  +1    -1    applets/taskmanager/package/contents/ui/Task.qml
M  +5    -4    applets/taskmanager/package/contents/ui/code/layout.js

https://invent.kde.org/plasma/plasma-desktop/-/commit/36cda2975a1e1d7771c7ea7aae73b0ebd089d5bc
Comment 7 Nate Graham 2024-04-29 14:43:09 UTC
*** Bug 447561 has been marked as a duplicate of this bug. ***