Bug 482918 - Tiled windows no longer get XDG_TOPLEVEL_STATE_TILED_* states set as expected
Summary: Tiled windows no longer get XDG_TOPLEVEL_STATE_TILED_* states set as expected
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: Quick Tiling (other bugs)
Version First Reported In: 6.0.1
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-03-08 20:04 UTC by orko
Modified: 2024-05-22 13:37 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description orko 2024-03-08 20:04:32 UTC
SUMMARY


STEPS TO REPRODUCE
1. Launch any app, e.g. firefox or chromium with ozone/wayland backend enabled (or any other app)
2. Tile the window to half of the screen or a corner of the screen by dragging it or using a keyboard shortcut

OBSERVED RESULT

The rounded corners remain even in tiled mode.

Debugging with chromium using `--enable-logging=stderr --vmodule="*wayland*=1"` it was found that the compositor does not set the `XDG_TOPLEVEL_STATE_TILED_*` states in the `xdg_toplevel.configure` event when window is tiled. It was being set correctly in Plasma 5.

EXPECTED RESULT
No rounded corners should be seen.
The compositor should set the tiled states in the `xdg_toplevel.configure` event.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Arch Linux 
(available in About System)
KDE Plasma Version: 6.0.1
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-03-10 20:52:47 UTC
Can reproduce.
Comment 2 Zamundaaa 2024-03-11 00:29:56 UTC
This is unfortunately because GTK is broken: https://invent.kde.org/plasma/kwin/-/merge_requests/5170
It was finally fixed in GTK a week ago, so we can probably revert that for 6.1
Comment 3 Vlad Zahorodnii 2024-03-11 12:02:50 UTC
(In reply to Zamundaaa from comment #2)
> This is unfortunately because GTK is broken:
> https://invent.kde.org/plasma/kwin/-/merge_requests/5170
> It was finally fixed in GTK a week ago, so we can probably revert that for
> 6.1

Yeah it should be okay-ish for 6.1. For 6.0, it's still going to cause problems because not even Arch ships gtk3 with the fix.
Comment 4 Zamundaaa 2024-05-22 13:37:16 UTC
The relevant commit was 6.0-only, and we haven't introduced a similar workaround in master, so this issue should be gone in 6.1