Bug 482829 - Plasma-styled buttons don't show their pressed state when animations are disabled
Summary: Plasma-styled buttons don't show their pressed state when animations are disa...
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.248.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-08 07:47 UTC by Dipta Biswas
Modified: 2024-03-11 13:37 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1
Sentry Crash Report:


Attachments
Recording (326.04 KB, video/webm)
2024-03-08 08:02 UTC, Dipta Biswas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dipta Biswas 2024-03-08 07:47:36 UTC
SUMMARY
I want to keep digital clock applet open, so I click the keep open button on the top left. Now the digital clock is open but the keep open button has no visual change. It used to have an outline in plasma 5. Reproducible using breeze as well as my custom plasma theme under development.
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Open a plasmoid
2. Click on keep open button
3. Click outside plasmoid

OBSERVED RESULT
Plasmoid is kept open but no visual change in button

EXPECTED RESULT
In breeze plasma theme, there should be an outline. In oxygen, there should be a grayish background

SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 40
KDE Plasma Version: 6.0.0
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.8.0-0.rc6.49.fc40.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 2 × AMD E2-9000e RADEON R2, 4 COMPUTE CORES 2C+2G
Memory: 3.7 GiB of RAM
Graphics Processor: AMD Radeon R2 Graphics
Manufacturer: HP
Product Name: HP Laptop 14-bw0xx

ADDITIONAL INFORMATION
Comment 1 Dipta Biswas 2024-03-08 08:02:17 UTC
Created attachment 166685 [details]
Recording
Comment 2 Nate Graham 2024-03-08 23:50:10 UTC
I'm afraid this is a bug in the 3rd-party Plasma style you're using.
Comment 3 Dipta Biswas 2024-03-10 09:58:06 UTC
Hi, Nate. I believe my theme is not buggy. I believe the bug is caused by moving the animation speed slider to instant. The issue can be reproduced by creating a new user account and moving the animation speed to instant, even when using the breeze theme. Otherwise, it may be a bug in Fedora 40 RPMs.
Comment 4 Nate Graham 2024-03-10 15:26:48 UTC
Oh wow, you're right. That detail about the animation speed was very relevant, thanks.
Comment 5 Bug Janitor Service 2024-03-10 16:46:37 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1077
Comment 6 Nate Graham 2024-03-11 13:37:35 UTC
Git commit 3478fa071571dbf759ba710a4a0626ea2e345d20 by Nate Graham.
Committed on 10/03/2024 at 16:41.
Pushed by ngraham into branch 'master'.

Completely disable animations when animations are globally disabled

Right now we rely on this happening implicitly when the relevant
duration values become 0. But an animation with a 0 duration does not
work as expected with certain types of QtQuick Animators. In addition,
even if it does work, a 0-duration animation is inefficient, doing
extra work for no reason. Let's disable the animations entirely when
we know the user has globally disabled animations.
FIXED-IN: 6.1

M  +1    -0    src/declarativeimports/plasmacomponents3/BusyIndicator.qml
M  +1    -0    src/declarativeimports/plasmacomponents3/CheckIndicator.qml
M  +1    -0    src/declarativeimports/plasmacomponents3/Dial.qml
M  +1    -0    src/declarativeimports/plasmacomponents3/MenuItem.qml
M  +1    -0    src/declarativeimports/plasmacomponents3/PageIndicator.qml
M  +6    -3    src/declarativeimports/plasmacomponents3/RadioIndicator.qml
M  +3    -0    src/declarativeimports/plasmacomponents3/RoundButton.qml
M  +1    -0    src/declarativeimports/plasmacomponents3/ScrollBar.qml
M  +2    -1    src/declarativeimports/plasmacomponents3/Slider.qml
M  +2    -1    src/declarativeimports/plasmacomponents3/SpinBox.qml
M  +2    -1    src/declarativeimports/plasmacomponents3/SwitchIndicator.qml
M  +3    -1    src/declarativeimports/plasmacomponents3/TextField.qml
M  +4    -1    src/declarativeimports/plasmacomponents3/private/ButtonFocus.qml
M  +4    -1    src/declarativeimports/plasmacomponents3/private/ButtonShadow.qml
M  +4    -1    src/declarativeimports/plasmacomponents3/private/FlatButtonBackground.qml
M  +8    -2    src/declarativeimports/plasmacomponents3/private/RaisedButtonBackground.qml
M  +2    -0    src/declarativeimports/plasmaextracomponents/qml/ActionTextField.qml
M  +2    -0    src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml
M  +1    -0    src/declarativeimports/plasmaextracomponents/qml/Highlight.qml

https://invent.kde.org/plasma/libplasma/-/commit/3478fa071571dbf759ba710a4a0626ea2e345d20