Bug 482813 - [Wayland] Two-finger tap doesn't work on Task Manager widgets
Summary: [Wayland] Two-finger tap doesn't work on Task Manager widgets
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (other bugs)
Version First Reported In: 6.0.2
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression, wayland-only
: 484593 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-03-08 04:34 UTC by elman
Modified: 2024-04-03 16:11 UTC (History)
7 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/6e4d4ea5cdb37df35a913d0c1f3ee06e100d1467
Version Fixed In: 6.0.4
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description elman 2024-03-08 04:34:36 UTC 
SUMMARY
***
I have configured two-finger tap to right click. When I pin an application to task manager and them two-finger tap it, nothing happens.
***

STEPS TO REPRODUCE
1. Configure two-finger tap to right click.
2. Pin an application to icons only task manager.
3. Two-finger tap the icon.

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
Context menu for right click should appear.

SOFTWARE/OS VERSIONS
Operating System: EndeavourOS
KDE Plasma Version: 6.0.1
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.7.8-arch1-1 (64-bit)
Graphics Platform: Wayland

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-03-08 23:43:09 UTC 
Works for me. Does a two-finger tap to right-click fail anywhere else? Or only here?
Comment 2 elman 2024-03-09 01:08:09 UTC 
Just on those icons in icons only task manager. Works on application launcher, empty space, tray icons and desktop.
Comment 3 Dominic 2024-03-09 16:11:25 UTC 
Also experiencing this, was just about to open another issue but caught this one first.

SUMMARY
Two finger tapping on icons within the task menu panel does not do anything and doesn't mimic the same behavior if you were right-clicking with a physical mouse.

STEPS TO REPRODUCE
1. Ensure "Tap-to-click" and "Press anywhere with two fingers" is enabled within Touch-pad settings
2. Have an Icons-only task menu with at least one icon for an application.
3. Attempt to two-finger tap to open a context menu for the icon, observe behavior does not occur as expected.

OBSERVED RESULT
Two finger tapping on an icon within the Icons-only task menu panel acts as neither a click to open the selected window, nor does a context menu appear.

EXPECTED RESULT
As a user, I should be able to two finger tap with a laptop touch-pad on icons within the Icons-only task menu panel to show the context-menu for that application.

ADDITIONAL INFORMATION
OS: Arch Linux x86_64 
Host: ROG Zephyrus G14 GA402RJ 1.0 
Kernel: 6.7.9-arch1-1
Shell: bash 5.2.26 
Resolution: 2560x1600 
DE: Plasma 6.0.1 
WM: kwin 
WM Theme: Kanagawa 
Theme: [Plasma], Kanagawa-B [GTK2/3] 
Icons: [Plasma], breeze-dark [GTK2/3] 
CPU: AMD Ryzen 9 6900HS with Radeon Graphics (16) @ 4.935GHz 
GPU: AMD ATI Radeon 680M
Comment 4 thegu5.disposable 2024-03-11 16:56:53 UTC 
Can reproduce, same summary/steps/results.

ADDITIONAL INFORMATION:
OS: Nobara Linux 39
KDE Plasma Version: 6.0.1
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel: 6.7.5-200.fsync.fc39.x86_64
Graphics Platform: Wayland
Comment 5 m5kro 2024-03-19 02:05:43 UTC 
Can reproduce, really starting to bug me.

OS: EndeavorOS x89_64
Kernel: 6.8.1-arch1-1
KDE Plasma Version: 6.0.2
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Graphics Platform: Wayland
Comment 6 Nate Graham 2024-03-19 19:02:48 UTC 
I'm a dummy; I was tapping in the wrong place. Can reproduce. I'll see if I can fix it. Hopefully it's something stupid and easy.
Comment 7 Nate Graham 2024-03-19 19:06:35 UTC 
Nope, ignore me, I was an even bigger dummy and didn't have tap-to-click turned on while testing again just now. With it turned on, I can do a two-finger tap on pinned app icons and get a menu. Browsing the code, I see no reason why this shouldn't work only there, but work everywhere else. It makes no sense.

For all of you affected, if you turn *off* tap-to-click, can you do a right-click on pinned app icons by doing the standard "press-down on the pad with two fingers" style of right-click?
Comment 8 thegu5.disposable 2024-03-19 22:23:46 UTC 
Disabling tap-to-click and pressing down normally shows the menu like it should.
Comment 9 elman 2024-03-20 09:48:08 UTC 
> Can you do a right-click on pinned app icons by doing the standard "press-down on the pad with two fingers" style of right-click?

I don't have press-down pad. I have separate button for right-click and that works every time, irrelevant of tap-to-click setting.
Comment 10 Nate Graham 2024-04-02 21:31:44 UTC 
*** Bug 484593 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2024-04-02 21:32:46 UTC 
From the duplicate bug, apparently this was caused by https://invent.kde.org/plasma/plasma-desktop/-/commit/f2160c3b68c4adcac6c399e14a88b80c23343d55.
Comment 12 seanwhearn 2024-04-02 21:48:04 UTC 
This bug isn't limited to the icons-only task manager. It affects the traditional full-text task manager in exactly the same way.
Comment 13 Nate Graham 2024-04-02 23:40:18 UTC 
They share code, so I'm not surprised.
Comment 14 Fushan Wen 2024-04-03 15:56:35 UTC 
Git commit c9ae061d39402324863e92be4602f5f7286d8973 by Fushan Wen.
Committed on 03/04/2024 at 15:52.
Pushed by fusionfuture into branch 'master'.

Revert "applets/taskmanager: simplify right press handling"

This reverts commit f2160c3b68c4adcac6c399e14a88b80c23343d55.

Apparently in some hardware the clock is not reliable so in two adjacent
event loops the timer often gets the same time point, which prevents the
long pressed timer from being activated before the release event.
FIXED-IN: 6.0.4

M  +8    -3    applets/taskmanager/package/contents/ui/Task.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/c9ae061d39402324863e92be4602f5f7286d8973
Comment 15 Fushan Wen 2024-04-03 16:11:05 UTC 
Git commit 6e4d4ea5cdb37df35a913d0c1f3ee06e100d1467 by Fushan Wen.
Committed on 03/04/2024 at 15:59.
Pushed by fusionfuture into branch 'Plasma/6.0'.

Revert "applets/taskmanager: simplify right press handling"

This reverts commit f2160c3b68c4adcac6c399e14a88b80c23343d55.

Apparently in some hardware the clock is not reliable so in two adjacent
event loops the timer often gets the same time point, which prevents the
long pressed timer from being activated before the release event.
FIXED-IN: 6.0.4


(cherry picked from commit c9ae061d39402324863e92be4602f5f7286d8973)

M  +8    -3    applets/taskmanager/package/contents/ui/Task.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/6e4d4ea5cdb37df35a913d0c1f3ee06e100d1467