Bug 482736 - First item in first column of Kicker search results is hidden by search field
Summary: First item in first column of Kicker search results is hidden by search field
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) widget (show other bugs)
Version: 6.0.1
Platform: Gentoo Packages Linux
: HI normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6
: 482771 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-03-07 15:49 UTC by Martin Bednar
Modified: 2024-03-11 15:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.2
Sentry Crash Report:


Attachments
showing file result hidden (89.27 KB, image/png)
2024-03-07 15:49 UTC, Martin Bednar
Details
showcasing bookmarks (165.40 KB, image/png)
2024-03-07 15:49 UTC, Martin Bednar
Details
showcasing commandline (114.65 KB, image/png)
2024-03-07 15:50 UTC, Martin Bednar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Bednar 2024-03-07 15:49:39 UTC
Created attachment 166607 [details]
showing file result hidden

When a kicker search produces no applications results, the applications pane is hidden.
In this case, all of the "bookmarks" "files" and "command line" panes have their lowermost result hidden by the search bar. 
This result is merely hidden, accessible if the pane is longer than the search bar.

STEPS TO REPRODUCE
1. Open kicker
2. search for something with no applications result
3. navigate with keyboard to select the hidden result

EXPECTED RESULT:
bookmarks/file results should behave the same as applications results: not be covered by the search bar

KDE Plasma Version: 6.0.1
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Comment 1 Martin Bednar 2024-03-07 15:49:59 UTC
Created attachment 166608 [details]
showcasing bookmarks
Comment 2 Martin Bednar 2024-03-07 15:50:16 UTC
Created attachment 166609 [details]
showcasing commandline
Comment 3 Martin Bednar 2024-03-07 15:52:17 UTC
Comment on attachment 166609 [details]
showcasing commandline

This file search has 3 results, command line 1 result.
Comment 4 Nate Graham 2024-03-07 21:59:22 UTC
Can reproduce.
Comment 5 Bug Janitor Service 2024-03-08 15:53:40 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2099
Comment 6 Nate Graham 2024-03-08 17:23:26 UTC
Git commit e0582b167be904abedb2332ad3f459eab52e1d4e by Nate Graham, on behalf of Marco Martin.
Committed on 08/03/2024 at 17:23.
Pushed by ngraham into branch 'master'.

Rework logic to know who is the first visible results view

We have a horizontal layout of runner results that separate the results
by category.

In order to show enough space for the text field and to disable the
first separator line, it assumed the item with index===0 was the first
element.

However if there aren't results which are applications, this assumption
would break and the layout was wrong, so check that this column is
actually the first visible child.
FIXED-IN: 6.0.2

M  +1    -1    applets/kicker/package/contents/ui/MenuRepresentation.qml
M  +8    -7    applets/kicker/package/contents/ui/RunnerResultsList.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/e0582b167be904abedb2332ad3f459eab52e1d4e
Comment 7 Nate Graham 2024-03-08 17:47:05 UTC
Git commit f9f87a3c89c6082e8171c4e87df01fe8df8280c9 by Nate Graham, on behalf of Marco Martin.
Committed on 08/03/2024 at 17:25.
Pushed by ngraham into branch 'Plasma/6.0'.

Rework logic to know who is the first visible results view

We have a horizontal layout of runner results that separate the results
by category.

In order to show enough space for the text field and to disable the
first separator line, it assumed the item with index===0 was the first
element.

However if there aren't results which are applications, this assumption
would break and the layout was wrong, so check that this column is
actually the first visible child.
FIXED-IN: 6.0.2


(cherry picked from commit e0582b167be904abedb2332ad3f459eab52e1d4e)

f5237fb8 Rework logic to know who is the first visible results view
db6d7462 fix resizing

M  +1    -1    applets/kicker/package/contents/ui/MenuRepresentation.qml
M  +8    -7    applets/kicker/package/contents/ui/RunnerResultsList.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/f9f87a3c89c6082e8171c4e87df01fe8df8280c9
Comment 8 Nate Graham 2024-03-08 23:31:06 UTC
*** Bug 482771 has been marked as a duplicate of this bug. ***
Comment 9 Martin Bednar 2024-03-11 15:47:58 UTC
Indeed, this is a lot better. Thanks!