Bug 482605 - Magnifier no longer works
Summary: Magnifier no longer works
Status: RESOLVED WORKSFORME
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: 24.02.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Noah Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-06 22:53 UTC by Jet
Modified: 2024-03-09 05:19 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jet 2024-03-06 22:53:15 UTC
The mangifier when resizing the bounding box of a square selection no longer works after the KDE 6 update
Comment 1 Noah Davis 2024-03-07 02:59:49 UTC
(In reply to Jet from comment #0)
> The mangifier when resizing the bounding box of a square selection no longer
> works after the KDE 6 update

In the settings dialog, do you have "Show magnifier" checked? Previously, this setting was not respected, but now it is. However, the setting has always been off by default. We are considering replacing the setting with a toggle between always showing the magnifier and only showing it while Shift is held. Currently it is only shown while Shift is held.
Comment 2 Jet 2024-03-07 03:24:50 UTC
(In reply to Noah Davis from comment #1)
> (In reply to Jet from comment #0)
> > The mangifier when resizing the bounding box of a square selection no longer
> > works after the KDE 6 update
> 
> In the settings dialog, do you have "Show magnifier" checked? Previously,
> this setting was not respected, but now it is. However, the setting has
> always been off by default. We are considering replacing the setting with a
> toggle between always showing the magnifier and only showing it while Shift
> is held. Currently it is only shown while Shift is held.

Yes, I have it checked, I also tried un- and re-checking it to make sure it wasn't just the settings panel being funky
Comment 3 Nate Graham 2024-03-07 17:30:24 UTC
Does it work if you hold down the Shift key while dragging?
Comment 4 Jet 2024-03-07 18:12:17 UTC
(In reply to Nate Graham from comment #3)
> Does it work if you hold down the Shift key while dragging?

Well yes it does, but it didn't require holding shift before, is this intended?
Comment 5 Noah Davis 2024-03-07 18:39:26 UTC
(In reply to Jet from comment #4)
> (In reply to Nate Graham from comment #3)
> > Does it work if you hold down the Shift key while dragging?
> 
> Well yes it does, but it didn't require holding shift before, is this
> intended?

Yes, mainly because that was how it was originally supposed to work in 22.12. You can also see in the help box for the rectangle selection that the magnifier is only supposed to show while shift is held, but the behavior was unintentionally changed somewhere between 23.04 and 24.02. The next version of Spectacle will have a better version of the setting with more explicit behavior: https://invent.kde.org/graphics/spectacle/-/merge_requests/338
Comment 6 Jet 2024-03-07 23:42:45 UTC
(In reply to Noah Davis from comment #5)
> (In reply to Jet from comment #4)
> > (In reply to Nate Graham from comment #3)
> > > Does it work if you hold down the Shift key while dragging?
> > 
> > Well yes it does, but it didn't require holding shift before, is this
> > intended?
> 
> Yes, mainly because that was how it was originally supposed to work in
> 22.12. You can also see in the help box for the rectangle selection that the
> magnifier is only supposed to show while shift is held, but the behavior was
> unintentionally changed somewhere between 23.04 and 24.02. The next version
> of Spectacle will have a better version of the setting with more explicit
> behavior: https://invent.kde.org/graphics/spectacle/-/merge_requests/338

Well in that case, i noticed that it isn't explained very well in the settings panel, and that if i hold shift, but not move the cursor, it wont appear until i do move it. I would expect the magnifier view to update independent of cursor movement
Comment 7 Noah Davis 2024-03-08 14:07:38 UTC
Git commit 37dc6a8839f56cc6daca1f125d1b83b7f6251508 by Noah Davis.
Committed on 08/03/2024 at 14:01.
Pushed by ndavis into branch 'master'.

Change showMagnifier setting to toggle between Never, Always and While holding the Shift key

Previously, it showed the magnifier only while the shift key was held or not at all.

M  +1    -1    src/Gui/ImageCaptureOverlay.qml
M  +4    -2    src/Gui/SelectionEditor.cpp
M  +27   -25   src/Gui/SettingsDialog/GeneralOptions.ui
M  +8    -3    src/Gui/SettingsDialog/spectacle.kcfg
M  +6    -2    src/Gui/ShortcutsTextBox.qml

https://invent.kde.org/graphics/spectacle/-/commit/37dc6a8839f56cc6daca1f125d1b83b7f6251508
Comment 8 Nate Graham 2024-03-08 20:35:54 UTC
It sounds like it was in fact working as expected and you need to hold the Shift key to use it. This will be customizable in the 24.05 release.
Comment 9 Noah Davis 2024-03-09 05:19:00 UTC
(In reply to Jet from comment #6)
> if i hold shift, but not move the cursor, it wont
> appear until i do move it. I would expect the magnifier view to update
> independent of cursor movement

It should appear next to the mouse cursor without needing to move the cursor. At least that's how it works for me.