Bug 482543 - When using a non-random slideshow ordering, remember the last-seen wallpaper the next time the slideshow plays
Summary: When using a non-random slideshow ordering, remember the last-seen wallpaper ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image Wallpaper (show other bugs)
Version: 6.0.1
Platform: Neon Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression
Depends on:
Blocks:
 
Reported: 2024-03-06 13:49 UTC by Ali
Modified: 2024-03-11 01:21 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ali 2024-03-06 13:49:04 UTC
SUMMARY
***
I choose wallpaper slideshow for lock screen. When I lock, its start slideshow from beginning, after hours and changing images I unlock. And if I lock again the circle its reset and start slideshow from beginning.
***

EXPECTED RESULT
Wallpaper slideshow continue from I unlock, even after reboot.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon 6.0
KDE Plasma Version: 6.0.0
KDE Frameworks Version: 6.0.0
Qt Version: 6.5.0-21-generic (64-bit)
Comment 1 Nate Graham 2024-03-06 19:37:31 UTC
I gather you set the order to something other than "Random"?
Comment 2 Ali 2024-03-09 06:04:48 UTC
(In reply to Nate Graham from comment #1)
> I gather you set the order to something other than "Random"?

No, Order is A to Z
Comment 3 Nate Graham 2024-03-10 03:15:41 UTC
Thanks.
Comment 4 Fushan Wen 2024-03-10 06:02:58 UTC
It should already, but on plasmashell shutdown the config is not saved.
Comment 5 Nate Graham 2024-03-10 06:21:30 UTC
(In reply to Fushan Wen from comment #4)
> It should already, but on plasmashell shutdown the config is not saved.

That sounds like it could be the cause of several other bug reports: Bug 481085, Bug 482469, Bug 482090, Bug 481113,and Bug 482773.
Comment 6 Nate Graham 2024-03-10 06:22:28 UTC
Also this bug report is about preserving the last-seen image for the slideshow on the lock screen specifically, where a plasmashell restart isn't necessarily going to happen.
Comment 7 Fushan Wen 2024-03-10 06:38:28 UTC
I can partially fix it, but in Qt6 objects in QML do not go through their dtors on application quit.
Comment 8 Bug Janitor Service 2024-03-10 06:38:46 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4035
Comment 9 Fushan Wen 2024-03-10 06:44:30 UTC
    Connections {
        enabled: root.pluginName === "org.kde.slideshow"
        target: Qt.application
        function onAboutToQuit() {
            root.configuration.writeConfig(); // Save the last position
        }
    }

This connection will save the config on application quit. The connection has to be in QML otherwise it's not called.
Comment 10 Fushan Wen 2024-03-11 01:02:28 UTC
Git commit e770ec489aedc4361583a972bc8cd4d2950dd698 by Fushan Wen.
Committed on 11/03/2024 at 01:02.
Pushed by fusionfuture into branch 'master'.

wallpapers/image: save the last position for slideshow on exit

The connection to aboutToQuit has to been in QML because on application quit QQuickItem doesn't go through its dtor.
FIXED-IN: 6.0.2

M  +14   -0    wallpapers/image/imagepackage/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/e770ec489aedc4361583a972bc8cd4d2950dd698
Comment 11 Fushan Wen 2024-03-11 01:21:05 UTC
Git commit d3b3c5384d688c0ba96017775d7e4909da033251 by Fushan Wen.
Committed on 11/03/2024 at 01:02.
Pushed by fusionfuture into branch 'Plasma/6.0'.

wallpapers/image: save the last position for slideshow on exit

The connection to aboutToQuit has to been in QML because on application quit QQuickItem doesn't go through its dtor.
FIXED-IN: 6.0.2


(cherry picked from commit e770ec489aedc4361583a972bc8cd4d2950dd698)

a5383221 wallpapers/image: save the last position for slideshow on exit

M  +14   -0    wallpapers/image/imagepackage/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/d3b3c5384d688c0ba96017775d7e4909da033251