Bug 482443 - okular - add build options for wayland (non X11) build options
Summary: okular - add build options for wayland (non X11) build options
Status: REPORTED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 24.02.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-05 07:01 UTC by onigino
Modified: 2024-03-05 18:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
x11-optional.patch (1.54 KB, patch)
2024-03-05 07:01 UTC, onigino
Details

Note You need to log in before you can comment on or make changes to this bug.
Description onigino 2024-03-05 07:01:48 UTC
Created attachment 166414 [details]
x11-optional.patch

At this point we shouldn't be assuming that just because linux is the platform that X11 libraries are going to exist.


Here is patch to offer better full wayland support where no X11 libs exist
Comment 1 Sune Vuorela 2024-03-05 07:47:00 UTC
Please submit the patch on invent.kde.org. 

I think there is things wrong (if built with x11 support and run under wayland; probably the most normal case), but it is better to discuss on invent.
Comment 2 Andreas Sturmlechner 2024-03-05 18:27:44 UTC
Thanks for your report. Indeed invent.kde.org is the way to go and get proper review.

I have submitted quite a few MRs upstream like yours, you can have a look in https://bugs.gentoo.org/813450 for inspiration.