Bug 482358 - Feature Request: Add --track-fds=error
Summary: Feature Request: Add --track-fds=error
Status: RESOLVED DUPLICATE of bug 362680
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-04 06:59 UTC by Vitaly Chikunov
Modified: 2024-04-26 11:31 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Chikunov 2024-03-04 06:59:05 UTC 
Now --track-fds=yes is only informational message (and it's even suppressed with -q), but sometimes (for using valgrind in CI testing) it's useful to consider it's an error if fd is leaked.

Please add --track-fds=error which would output (not suppressible) error message and exit with --error-exitcode if fd leak is occurred.

Thanks,
Comment 1 Paul Floyd 2024-03-04 15:08:01 UTC 
There is some work being done with fds, see https://bugs.kde.org/show_bug.cgi?id=471222

The main problem here is that the fd checking is done in core, not in any tool (specifically memcheck). Core doesn't have any error processing mechanisms (there was something in the past but it was removed). And if we make it an error we also want the suppression mechanism to work with it.
Comment 2 Mark Wielaard 2024-03-04 15:41:46 UTC 
See also https://bugs.kde.org/show_bug.cgi?id=362680 which contains a description how to resurrect CoreErrors (but no patch yet?)
Comment 3 Mark Wielaard 2024-04-26 11:31:04 UTC 
*** This bug has been marked as a duplicate of bug 362680 ***