Bug 482357 - hafasmgaterequesttest and efarequesttest fail based on unknown l10n/i18n factors
Summary: hafasmgaterequesttest and efarequesttest fail based on unknown l10n/i18n factors
Status: RESOLVED FIXED
Alias: None
Product: KPublicTransport
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 23.08.5
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Volker Krause
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-04 05:36 UTC by Alex Elsayed
Modified: 2024-03-05 16:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Elsayed 2024-03-04 05:36:28 UTC
STEPS TO REPRODUCE
1. Build kpublictransport with the C.UTF-8 locale, in Washington State (USA), possibly other factors
2. Run the tests

OBSERVED RESULT

    FAIL!  : HafasMgateRequestTest::testStopoverRequest(id-based-default) Compared values are not the same
       Actual   (m_nam.requests[0].data): "{\"auth\":{\"aid\":\"n91dB8Z77MLdoR0K\",\"type\":\"AID\"},\"client\":{\"id\":\"DB\",\"name\":\"DB Navigator\",\"type\":\"AND\",\"v\":19040000},\"ext\":\"DB.R20.12.b\",\"formatted\":false,\"lang\":\"de\",\"svcReqL\":[{\"meth\":\"StationBoard\",\"r"...
   Expected (postData)              : "{\"auth\":{\"aid\":\"n91dB8Z77MLdoR0K\",\"type\":\"AID\"},\"client\":{\"id\":\"DB\",\"name\":\"DB Navigator\",\"type\":\"AND\",\"v\":19040000},\"ext\":\"DB.R20.12.b\",\"formatted\":false,\"lang\":\"en\",\"svcReqL\":[{\"meth\":\"StationBoard\",\"r"...
       Loc: [/kpublictransport-23.08.5/autotests/hafasmgaterequesttest.cpp(95)]
    (more, similar lines)


    32:    Actual   (url)       : https://www2.vvs.de/vvs/XML_DM_REQUEST?outputFormat=XML&coordOutputFormat=WGS84[DD.ddddd]&language=de&type_dm=stop&name_dm=12345&itdDate=20230625&itdTime=0939&useRealtime=1&limit=12&mode=direct&ptOptionsActive=1&merge_dep=1&stateless=1&sessionID=0&requestID=0
    32:    Expected (requestUrl): https://www2.vvs.de/vvs/XML_DM_REQUEST?outputFormat=XML&coordOutputFormat=WGS84[DD.ddddd]&language=en&type_dm=stop&name_dm=12345&itdDate=20230625&itdTime=0939&useRealtime=1&limit=12&mode=direct&ptOptionsActive=1&merge_dep=1&stateless=1&sessionID=0&requestID=0
    32:    Loc: [/kpublictransport-23.08.5/autotests/efarequesttest.cpp(77)]
    (more, similar lines)

EXPECTED RESULT

These tests (where the only difference is expecting language "en" and receiving language "de") passing.

SOFTWARE/OS VERSIONS
Distro: Exherbo Linux, kernel 6.3.6
KDE Plasma Version: Plasma 23.08.0 updating to 23.08.5
KDE Frameworks Version: KDE Frameworks 5.110.0 updating to 5.115.0
Qt Version: 5.15.12 (relevant to this package) and 6.6.2
Comment 1 Volker Krause 2024-03-04 17:44:41 UTC
Git commit bdfb93dad323b611f8bbe09f6e9ef76dd026e3fd by Volker Krause.
Committed on 04/03/2024 at 17:44.
Pushed by vkrause into branch 'master'.

Fix locale overriding in request unit tests

M  +1    -1    autotests/efarequesttest.cpp
M  +1    -1    autotests/hafasmgaterequesttest.cpp

https://invent.kde.org/libraries/kpublictransport/-/commit/bdfb93dad323b611f8bbe09f6e9ef76dd026e3fd
Comment 2 Volker Krause 2024-03-05 16:39:43 UTC
Git commit 3fb5f8d6a32fe0a7cc7c70a63af70d760853d500 by Volker Krause.
Committed on 05/03/2024 at 16:39.
Pushed by vkrause into branch 'release/24.02'.

Fix locale overriding in request unit tests
(cherry picked from commit bdfb93dad323b611f8bbe09f6e9ef76dd026e3fd)

M  +1    -1    autotests/efarequesttest.cpp
M  +1    -1    autotests/hafasmgaterequesttest.cpp

https://invent.kde.org/libraries/kpublictransport/-/commit/3fb5f8d6a32fe0a7cc7c70a63af70d760853d500