Bug 482132 - When renaming an album, all collections' trees are expanded (windows and kde neon)
Summary: When renaming an album, all collections' trees are expanded (windows and kde...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-TreeView (show other bugs)
Version: 8.2.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-01 09:12 UTC by guenael
Modified: 2024-03-02 09:03 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.3.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description guenael 2024-03-01 09:12:09 UTC
SUMMARY
When renaming  an album, all collections' trees are expanded. In the collection tree where that album is, the whole tree is expanding. In other trees, only the first level. Observed on Win 10 and KDE Neon.


STEPS TO REPRODUCE
1. Right-click in the tree, select Collapse all albums
2. Open a tree, select an album and rename it


OBSERVED RESULT
All the trees expand as described

EXPECTED RESULT
The trees stay as they were with the album renamed.

SOFTWARE/OS VERSIONS
Windows: 10
KDE Plasma: Neon with Plasma 5.27
Comment 1 guenael 2024-03-01 09:14:23 UTC
Not a big bug, but a real annoyance when working on a large photo collection.
Comment 2 Maik Qualmann 2024-03-01 09:18:05 UTC
I only have Windows 10 here at the moment, but I can't reproduce this behavior.

Maik
Comment 3 caulier.gilles 2024-03-01 09:21:18 UTC
Same here with Kubuntu 22.04, 23.04, and 23.10. Not reproducible...
Comment 4 guenael 2024-03-01 09:31:56 UTC
Really? That's weird because this is a bug I have been observing for weeks so not a sudden issue for me. Note that I started using DIgikam al lot a few weeks ago (instead of once in a while).

Hum. I could send you a screen cast I presume - but that won't help a lot, will it ? Except showing that I have not gone postal.

What can I do then to help make it reproducible?
Comment 5 caulier.gilles 2024-03-01 09:33:41 UTC
yes, really. Qt6 is used everywhere on my computers, not Qt5
Comment 6 guenael 2024-03-01 11:47:31 UTC
I happen to have upgraded to Plasma 6 and Wayland - without knowing it beforehand it was such a huge upgrade. I was lucky though, only details don't work.

So I tested "my" tree bug and reproduced it once again. I also check through a remote session that it happens as well on my father's computer, a Win10 laptop. His digikam db and collections are different than mine, so it's not only "my" computer. A family bug? :-)

My current Neon conf:
Operating System: KDE neon 6.0
KDE Plasma Version: 6.0.0
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.5.0-21-generic (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-3770T CPU @ 2.50GHz
Memory: 15,4 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 4000

At this point, I can only hope that other users confirm the issue. I've made many trials to find a circumstance when the bug would NOT appear. I just found that the bug is even more obvious when the album renamed is situated not in the first collection but on the next ones (the whole trees expand).

However, it's just an annoyance and not a blocking thing, so no reason to make it a priority of any sort.

In all cases, thank both of you for your super quick reaction to try and reproduce it ; it's super nice to feel supported and it shows how serious the Digikam team is.

Best regards.
Comment 7 caulier.gilles 2024-03-01 12:54:42 UTC
Wayland is really a mess for the moment to use in production.

Use X11 instead.

Gilles Caulier
Comment 8 Maik Qualmann 2024-03-01 13:20:40 UTC
Wayland would be an option under Linux and Neon means that an Snap package from digiKam with Sandbox is probably used. But - that does not explain the behavior under Windows10. I have now added a very large album tree under Windows10 for testing, but the problem cannot be reproduced. I am also sure that such behavior would have been reported immediately by other users.

In the right mouse button menu do you use "Renaming" or the "Properties"?

Maik
Comment 9 Maik Qualmann 2024-03-01 13:55:08 UTC
Can you also please test the pre-release version of digiKam-8.3.0,
there is no database change in this version, download from here:

https://files.kde.org/digikam/

Maik
Comment 10 guenael 2024-03-02 01:20:39 UTC
There it is : using Right-Click and Rename works well. It's using "Properties" that provokes the trees expansion. I use Properties by habit, no reason else. Can you reproduce it now ? I'll tell you if this is also true on Win 10 tomorrow.

I don't use Snap. I installed Digikam using pkcon (eg Neon wrapper for apt). I install my apps with pkcon (generic + private ppa's) or flathub. Should I prefer one method? I installed Digikam on both my Win10 and my father's using chocolatey, for the record.

My father has a big db: 56 000 objects, several collections, lots of directories. Mine is much smaller, a few thousand photos and much simpler tree. I'm not sure this is part of the issue. I realize now that lead wasn't relevant, sorry for that.

I'll try the 8.3 pre-release.

I used X11 until yesterday and for now Wayland works ... perfectly well. Nothing to complain so far but I'll give it a try for a few days before making a decision. I'm agnostic on the matter and not technical enough to grasp the stakes between the two. I would not be surprised to move back to X11 : it has been fine for me for quite a few years.
Comment 11 Maik Qualmann 2024-03-02 06:56:16 UTC
Git commit c72441eedb8486d6da725ad9e16ea89d087169ce by Maik Qualmann.
Committed on 02/03/2024 at 06:54.
Pushed by mqualmann into branch 'master'.

fix a possible expansion of the album tree view after editing album properties
FIXED-IN: 8.3.0

M  +1    -1    NEWS
M  +6    -0    core/app/views/sidebar/albumfolderviewsidebarwidget.cpp
M  +2    -0    core/app/views/sidebar/albumfolderviewsidebarwidget.h
M  +1    -20   core/app/views/stack/itemiconview_albums.cpp
M  +4    -0    core/libs/album/engine/albummodificationhelper.cpp

https://invent.kde.org/graphics/digikam/-/commit/c72441eedb8486d6da725ad9e16ea89d087169ce
Comment 12 Maik Qualmann 2024-03-02 07:04:56 UTC
Git commit 94147e3e6a263e367ee6d0573385b49866e67f6a by Maik Qualmann.
Committed on 02/03/2024 at 07:03.
Pushed by mqualmann into branch 'master'.

remove unused album sorting application setting

M  +1    -18   core/libs/album/treeview/abstractalbumtreeview.cpp
M  +0    -3    core/libs/settings/applicationsettings.h
M  +0    -10   core/libs/settings/applicationsettings_albums.cpp
M  +0    -2    core/libs/settings/applicationsettings_p.cpp
M  +0    -1    core/libs/settings/applicationsettings_p.h

https://invent.kde.org/graphics/digikam/-/commit/94147e3e6a263e367ee6d0573385b49866e67f6a
Comment 13 Maik Qualmann 2024-03-02 07:08:51 UTC
In fact, I was only able to reproduce it in one of my test configurations by renaming it via the album properties. But the cause of the problem is clear and has now been resolved.

Maik
Comment 14 guenael 2024-03-02 09:03:52 UTC
Awesome! Thank you for your fortitude into solving this!

My best regards to you and Gilles, and the whole team for Digikam - this such useful tool. 

We use it for family memories, like many obviously. The important thing here it that it brings a lot of happiness in this world: that's an important job you're doing. 

And it keeps that away from surveillance states (that even democracies have become) and greedy global corporations. 

That's important work and something to be proud of. 

Sorry if that feels a bit over, I needed to express my gratitude!

Best regards.