Bug 481825 - Can not save editing "New Action" command in Plasma 6
Summary: Can not save editing "New Action" command in Plasma 6
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keys (show other bugs)
Version: 5.93.0
Platform: Neon Linux
: HI normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-02-25 18:24 UTC by Víctor
Modified: 2024-03-20 16:15 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.1


Attachments
Video with step-by-step (1.40 MB, video/webm)
2024-02-25 18:24 UTC, Víctor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Víctor 2024-02-25 18:24:34 UTC
Created attachment 166098 [details]
Video with step-by-step

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
There seems to be an issue in Plasma 6's System Settings > Keyboard > Shortcuts module, where saving commands or script paths for new actions is not working.

STEPS TO REPRODUCE
1. Go to System Settings > Keyboard > Shortcuts
2. Click on "+Add New" and select "Command or Script".
3. Type a command or choose a script path.
4. Save the new acction clicking on "Add".
5. Click in edit option over the pen icon in the saved action.
6. Change the command or script path.
7. Click on "Save" button.


OBSERVED RESULT
Clicking on Save button does not save the edited acction.

EXPECTED RESULT
Clicking on Save button must saves the edited acction.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Testing Edition
KDE Plasma Version: 6.0.0
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.5.0-21-generic (64-bit)
Graphics Platform: Wayland
Comment 1 duha.bugs 2024-02-25 18:34:18 UTC
Can reproduce -> confirming:
Operating System: Arch Linux 
KDE Plasma Version: 6.0.80
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.2
Kernel Version: 6.7.5-arch1-1 (64-bit)
Graphics Platform: Wayland
Comment 2 Nate Graham 2024-02-29 17:26:13 UTC
Can also reproduce. Clicking the save button throws an error:

> qrc:/kcm/kcm_keys/main.qml:404: Error: Cannot assign to non-existent property "label"
Comment 3 Nate Graham 2024-02-29 17:28:30 UTC
It looks like the command is actually changed, it's just the label in the UI that doesn't get changed, and the dialog doesn't go away due to the error interrupting the normal command flow.
Comment 4 Bug Janitor Service 2024-02-29 17:34:22 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2072
Comment 5 Nate Graham 2024-02-29 17:45:37 UTC
Git commit e9600f773fdbcba72778a1d3f36d25290565bbcf by Nate Graham.
Committed on 29/02/2024 at 17:31.
Pushed by ngraham into branch 'master'.

kcms:keys: fix changing command text or path

The code was trying to change an item by its ID that is dynamically
instantated within a delegate; that won't work.

Instead we need to change a top-level property on the delegate itself
and bubble that change down to its contentItem.
FIXED-IN: 6.0.1

M  +6    -3    kcms/keys/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/e9600f773fdbcba72778a1d3f36d25290565bbcf
Comment 6 Nate Graham 2024-02-29 18:58:03 UTC
Git commit 7f70e727f1c54b1b305f4f6c510c1e947066013e by Nate Graham.
Committed on 29/02/2024 at 18:51.
Pushed by ngraham into branch 'Plasma/6.0'.

kcms:keys: fix changing command text or path

The code was trying to change an item by its ID that is dynamically
instantated within a delegate; that won't work.

Instead we need to change a top-level property on the delegate itself
and bubble that change down to its contentItem.
FIXED-IN: 6.0.1


(cherry picked from commit e9600f773fdbcba72778a1d3f36d25290565bbcf)

M  +6    -3    kcms/keys/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/7f70e727f1c54b1b305f4f6c510c1e947066013e