Bug 481392 - The line seperating the attached side panel from the main view should imho stop where it meets the horizontal line above the status bar
Summary: The line seperating the attached side panel from the main view should imho st...
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 24.01.95
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-02-16 01:57 UTC by 31113
Modified: 2024-02-17 03:23 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot of the line and where it should stop (50.04 KB, image/png)
2024-02-16 01:57 UTC, 31113
Details

Note You need to log in before you can comment on or make changes to this bug.
Description 31113 2024-02-16 01:57:15 UTC
Created attachment 165847 [details]
screenshot of the line and where it should stop

SUMMARY
The line seperating the attached side panel from the main view should stop where it meets the horizontal line above the status bar. Imho it is from that point on an unnecessary line, it doesn't look great when you have window borders enabled and the side panel and the status bar did not have such a seperator before the otherwise very welcome upgrade to a more frameless breeze, so it also shouldn't be needed now.

STEPS TO REPRODUCE

1. Open dolphin with at least one panel active

OBSERVED RESULT 

the vertical line continues after meeting the horizontal line above the status bar

EXPECTED RESULT
The vertical line between the main view and the attachable side panels should stop when it meets a horizontal line. 


SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.93.0
KDE Frameworks Version: 5.249.0
Qt Version: 6.7.0
Kernel Version: 6.7.4-arch1-1 (64-bit)
Graphics Platform: Wayland
Comment 1 Nate Graham 2024-02-16 20:08:22 UTC
The current look is intentional, sorry. If the line didn't go all the way to the bottom, then the sidebar would lack an unbroken visual line that makes it clearly look like a sidebar as in other KDE apps with sidebars.
Comment 2 31113 2024-02-16 23:01:41 UTC
(In reply to Nate Graham from comment #1)
> The current look is intentional, sorry. If the line didn't go all the way to
> the bottom, then the sidebar would lack an unbroken visual line that makes
> it clearly look like a sidebar as in other KDE apps with sidebars.

I never had an issue with that line in other apps, so I went through a bunch of kde apps to see what's different here. I think I have identified it. 

In other apps, the sidebar usually has a different background colour than the bottom bar below the main view, or  -in absence of a bar at the bottom - the main view itself. 

Also, there are some other kde apps that also have a status bar at the bottom, for example kid3, filelight and kate, and there the line and the sidebar usually end above the status bar and the horizontal line above the status bar goes all the way across. Though it is noteworthy that unlike in those examples, in dolphin the status bar contents have always been limited to only below the main view.

So there is in my opinion some inconsistency, but my proposed solution was false. Unless you really just want to keep it as it is (in which case, okay, fine, I'll get used to it), I have two (and a half) other ideas for your consideration based on my observations above.

1. Change the colour of the sidebar to match the main view instead of the status bar. -> looks like, for example, systemsettings pages that have a bar at the bottom

2. Change the colour of the sidebar to match the main view instead of the status bar and make the horizontal line above the statusbar extend all the way across and stop the vertical line of the sidebar above the statusbar -> looks like, for example, kate, filelight, kid3

(2b. Same as 2., without changing the colour of the sidebar. -> looks like no other app, but I can see the argument that having a different colour for the main view and  the sidebar just looks better in a file manager.)

If you don't want to do any of that, that's also fine, I'm not going to annoy you any further
Comment 3 31113 2024-02-16 23:20:25 UTC
I said no other app looks like proposal 2b and for kde apps this is true (to my knowledge), but it might still be worth mentioning that PCManFM-Qt from the lxqt project does it like that. Since it's another file manager using qt, I thought it might be relevant.
Comment 4 Doug 2024-02-17 03:23:19 UTC
I think another benefit of that line continuing to the bottom of the window is consistency when in dual pane mode.  It would look odd without that line there.