Created attachment 165839 [details] panel doing its thing SUMMARY When a window is positioned on the first pixel where where the panel unfloats, it will try to float again, continuously. STEPS TO REPRODUCE 1. Have a floating panel 2. Move a window into the position where the panel starts to unfloat OBSERVED RESULT See attached video EXPECTED RESULT Panel should decide on one position SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.93.0 KDE Frameworks Version: 5.249.0 Qt Version: 6.7.0 Kernel Version: 6.6.16-1-lts (64-bit) Graphics Platform: Wayland ADDITIONAL INFORMATION In case it is important, here my scree configuration: $ kscreen-doctor -o | grep -e Geometry -e Scale -e Modes Modes: [...] 2:3840x2160@120* [...] Geometry: 1280,0 3840x2160 Scale: 1 Modes: 0:2560x1440@60*! [...] Geometry: 0,0 1280x2276 Scale: 1.125
Can reproduce. It's our new dancing panel feature! A game you could play when you are bored : ) P.s. Just kidding
I think fractional scaling might be a key factor here.
Haha wow! FWIW I can't reproduce it with a right screen edge panel myself at 225% scale.
Oh this has nothing to do with fractional geometry -- this is because we change the geometry of the panel upon float/defloat, and the defloating zone is always calculated with respect to the actual geometry of the panel -- when the panel moves left, the defloating zone also moves left, thus making the panel float again...
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3907
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2040
Git commit ab9de16b11a714684ae689d04c43520ff04194bb by Yifan Zhu. Committed on 16/02/2024 at 20:42. Pushed by fanzhuyifan into branch 'master'. shell/panelview: calculate dodge geometry independent of floatingness The dodge/defloat geometry should be the same no matter the panel is floating or not. In addition, constrain it to the geometry of the current screen, so that content from other screens have no impact. Previously, the compensation for floatingness was done in Panel.qml, which made the code more complicated, and had rounding errors that caused the panel to continuously cycle between float and defloat. FIXED-IN: 6.0 M +18 -4 shell/panelview.cpp M +6 -0 shell/panelview.h https://invent.kde.org/plasma/plasma-workspace/-/commit/ab9de16b11a714684ae689d04c43520ff04194bb
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3913
Git commit 9309df10945cf092a5a855b8d34c6b024060b77b by Yifan Zhu. Committed on 16/02/2024 at 21:04. Pushed by fanzhuyifan into branch 'master'. Panel: use new API to calculate regionGeometry Previously the compensation for floatingness was done in qml, which had rounding errors that caused the panel to continuously float/defloat. Use new api that calculates regionGeometry independent of floatingness. This also simplifies the code. FIXED-IN: 6.0 M +2 -4 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/9309df10945cf092a5a855b8d34c6b024060b77b
Git commit 711ebf79e784fb1440a037dfec73b0b706d41556 by Yifan Zhu. Committed on 16/02/2024 at 21:03. Pushed by fanzhuyifan into branch 'Plasma/6.0'. shell/panelview: calculate dodge geometry independent of floatingness The dodge/defloat geometry should be the same no matter the panel is floating or not. In addition, constrain it to the geometry of the current screen, so that content from other screens have no impact. Previously, the compensation for floatingness was done in Panel.qml, which made the code more complicated, and had rounding errors that caused the panel to continuously cycle between float and defloat. FIXED-IN: 6.0 (cherry picked from commit ab9de16b11a714684ae689d04c43520ff04194bb) M +18 -4 shell/panelview.cpp M +6 -0 shell/panelview.h https://invent.kde.org/plasma/plasma-workspace/-/commit/711ebf79e784fb1440a037dfec73b0b706d41556
Git commit e3a270ef18ecc85624e2c835d2e49f6b1cca382b by Yifan Zhu. Committed on 16/02/2024 at 21:37. Pushed by fanzhuyifan into branch 'Plasma/6.0'. Panel: use new API to calculate regionGeometry Previously the compensation for floatingness was done in qml, which had rounding errors that caused the panel to continuously float/defloat. Use new api that calculates regionGeometry independent of floatingness. This also simplifies the code. FIXED-IN: 6.0 (cherry picked from commit 9309df10945cf092a5a855b8d34c6b024060b77b) M +2 -4 desktoppackage/contents/views/Panel.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/e3a270ef18ecc85624e2c835d2e49f6b1cca382b