Bug 481262 - option GPG, does not list my gpg certificate
Summary: option GPG, does not list my gpg certificate
Status: RESOLVED NOT A BUG
Alias: None
Product: okular
Classification: Applications
Component: PDF backend (show other bugs)
Version: 23.08.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-12 12:12 UTC by Philippe ROUBACH
Modified: 2024-02-20 13:57 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe ROUBACH 2024-02-12 12:12:24 UTC
SUMMARY

if I choose the option "GPG" in PDF backend settings
then
okular does not display the list of the OpenPGP certificate created by kmail


STEPS TO REPRODUCE
1. go to Okular settings > render backend settings > PDF
2. choose "GPG"
3. 

OBSERVED RESULT

the list of certificates is empty

EXPECTED RESULT

the list of certificates contains the OpenPGP certificates created by kmail

Operating System: openSUSE Tumbleweed 20240209
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.114.0
Qt Version: 5.15.12

ADDITIONAL INFORMATION
Comment 1 Sune Vuorela 2024-02-12 12:47:15 UTC
the gpg backend setting is still s/mime and not openpgp, so you need s/mime certificates, just like for the nss backend.

The pdf standard specifies s/mime for signing pdfs.
Comment 2 Ingo Klöcker 2024-02-12 20:28:01 UTC
Maybe we should change the name of the backend to "GnuPG (S/MIME)" (or "GPGSM", but many won't understand this) to make this more obvious. "GPG" is actually very wrong because gpg is the name of the OpenPGP tool of the GnuPG suite.
Comment 3 Albert Astals Cid 2024-02-12 21:25:17 UTC
(In reply to Ingo Klöcker from comment #2)
> Maybe we should change the name of the backend to "GnuPG (S/MIME)" (or
> "GPGSM", but many won't understand this) to make this more obvious. "GPG" is
> actually very wrong because gpg is the name of the OpenPGP tool of the GnuPG
> suite.

that  makes sense, not the first person to be confused by the naming. Sune?
Comment 4 Sune Vuorela 2024-02-13 08:13:38 UTC
(In reply to Albert Astals Cid from comment #3)
> (In reply to Ingo Klöcker from comment #2)
> > Maybe we should change the name of the backend to "GnuPG (S/MIME)" (or

> that  makes sense, not the first person to be confused by the naming. Sune?

Sure. I didn't have any good ideas at the time, but I kind of prepared the code for it

https://invent.kde.org/graphics/okular/-/blob/master/generators/poppler/pdfsettingswidget.cpp#L35

If one option should be 
> GnuPG (S/MIME) 
what should the other be
> Netscape NSS 
> NSS
> Firefox Certificate store
Comment 5 Ingo Klöcker 2024-02-13 08:37:53 UTC
I think a good name for the NSS backend depends on how it behaves on different OSes, i.e. if it uses the Windows/macOS certificate store on Windows/macOS then "Firefox Certificate store" is probably not a good name. And I guess most people don't know that Mozilla Firefox was once called Netscape.
Comment 6 Philippe ROUBACH 2024-02-13 08:48:06 UTC
(In reply to Ingo Klöcker from comment #2)
> Maybe we should change the name of the backend to "GnuPG (S/MIME)" (or
> "GPGSM", but many won't understand this) to make this more obvious. "GPG" is
> actually very wrong because gpg is the name of the OpenPGP tool of the GnuPG
> suite.

A good GUI is a teacher GUI.
Why not using a text not on the button but beside the option when we select the option. This text would explain what certificate is expected.
Comment 7 Sune Vuorela 2024-02-13 14:25:49 UTC
(In reply to Ingo Klöcker from comment #5)
> I think a good name for the NSS backend depends on how it behaves on
> different OSes, i.e. if it uses the Windows/macOS certificate store on
> Windows/macOS then "Firefox Certificate store" is probably not a good name.
> And I guess most people don't know that Mozilla Firefox was once called
> Netscape.

Afaik, it still uses the firefox cert store on all platforms.
Comment 8 Albert Astals Cid 2024-02-13 22:50:31 UTC
NSS is the better name

We use the current user Firefox NSS database by default if it exists, but users can select any folder containing an NSS database.
Comment 9 Bug Janitor Service 2024-02-19 15:36:38 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/928
Comment 10 Albert Astals Cid 2024-02-19 21:39:05 UTC
Git commit 8a6d86ab1961b51ffc9f86ef2ebcbe86a8d4ae3c by Albert Astals Cid, on behalf of Sune Vuorela.
Committed on 19/02/2024 at 21:39.
Pushed by aacid into branch 'master'.

Better user strings for signature settings

M  +9    -4    generators/poppler/pdfsettingswidget.cpp

https://invent.kde.org/graphics/okular/-/commit/8a6d86ab1961b51ffc9f86ef2ebcbe86a8d4ae3c
Comment 11 Sune Vuorela 2024-02-20 13:57:55 UTC
Git commit 3518099a08f0b129e6be8c8216ecb5fc0bf38273 by Sune Vuorela.
Committed on 20/02/2024 at 13:57.
Pushed by sune into branch 'release/24.02'.

Better user strings for signature settings

M  +9    -4    generators/poppler/pdfsettingswidget.cpp

https://invent.kde.org/graphics/okular/-/commit/3518099a08f0b129e6be8c8216ecb5fc0bf38273