Bug 481231 - Add the version number to the welcome title itself
Summary: Add the version number to the welcome title itself
Status: RESOLVED NOT A BUG
Alias: None
Product: skrooge
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Other
: NOR normal
Target Milestone: 25.1.0
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-11 16:05 UTC by Emir SARI
Modified: 2024-02-13 20:41 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emir SARI 2024-02-11 16:05:43 UTC
In the Welcome to %1 text, the version number is not included. When it is localised in a language with a different word order, it becomes alienated at the very end, like "%1 to welcome" + about.version(). Having it like ("Welcome to %1 %2", name, version) would make it much better.

Now I checked the code out, wanting to fix it myself, but did not understand a thing :D. That's why opening the report here.
Comment 1 Stephane MANKOWSKI 2024-02-11 20:38:21 UTC
The "Welcome to %1" message is a part and the version is another.
Those information can be used in templates.
This is the case here, the template uses those information like this:
<h2 style="margin-top: 0px;">{{ about_welcome }} {{about_version}}</h2>

But this could be different.

So, there is no way to fix this without a huge impact on existing templates.
Comment 2 Emir SARI 2024-02-13 20:41:16 UTC
Thanks for the reply, it's alright then!