Bug 481216 - Text not readable when using a Breeze Dark
Summary: Text not readable when using a Breeze Dark
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_thunderbolt (show other bugs)
Version: 5.93.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6
: 484841 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-02-11 12:47 UTC by Iyán M. V.
Modified: 2024-08-14 22:58 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0
Sentry Crash Report:


Attachments
Thunderbolt settings with Breeze Dark (205.30 KB, image/png)
2024-02-11 12:47 UTC, Iyán M. V.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Iyán M. V. 2024-02-11 12:47:38 UTC
Created attachment 165748 [details]
Thunderbolt settings with Breeze Dark

SUMMARY
While the rest of the settings adapt correctly to Breeze Dark, Thunderbolt devices list uses a black font, hard to read with the dark theme (see attached screenshot)


STEPS TO REPRODUCE
1. Change to Beeze Dark
2. Go to Thunderbolt settings

OBSERVED RESULT
Dark text with dark background

EXPECTED RESULT
White text with dark background

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.93.0
KDE Frameworks Version: 5.249.0
Qt Version: 6.7.0
Kernel Version: 6.7.4-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 8 × 11th Gen Intel® Core™ i5-1135G7 @ 2.40GHz
Memory: 15.3 GiB of RAM
Graphics Processor: Mesa Intel® Xe Graphics
Manufacturer: LENOVO
Product Name: 20XYCTO1WW
System Version: ThinkPad X1 Yoga Gen 6
Comment 1 Patrick Silva 2024-04-01 10:39:27 UTC
*** Bug 484841 has been marked as a duplicate of this bug. ***
Comment 2 Bug Janitor Service 2024-08-13 20:25:27 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-thunderbolt/-/merge_requests/39
Comment 3 ratijas 2024-08-14 17:20:24 UTC
Git commit 3f8a85355d3ae43a31960ac7cb170e7cb0c4c127 by ivan tkachenko.
Committed on 13/08/2024 at 20:03.
Pushed by ratijas into branch 'master'.

kcm: Fix usage of Kirigami.Theme colors

Kirigami.Theme attached property can not be meaningfully used form a
stateless JavaScript module without a context Item instance, because,
well, it is designed to be an attached property after all! It attaches
to an Item, and reads values based on a context and parent chain of it.

Instead, we have few options:

a) Turn the module into a stateful script. This is horrible for scripts
which are to be reused from more than one QML component, because they
rely on external imports from those QML files.

b) Pass the context Item to the function and rewrite the assignments to
query the attached properties from that Item. Sounds good and type-safe.

c) Return only names of the respective color properties, so that the
client code may query them on any number of any Items they like. This
is the least intrusive option, and does not fetch colors unnecessarily
for the DeviceView component which doesn't currently use it anyway.

M  +1    -1    src/kcm/ui/DeviceList.qml
M  +3    -3    src/kcm/ui/utils.js

https://invent.kde.org/plasma/plasma-thunderbolt/-/commit/3f8a85355d3ae43a31960ac7cb170e7cb0c4c127
Comment 4 ratijas 2024-08-14 17:20:32 UTC
Git commit 7de63e92a05d0ecfdd64523843a37ef961deb30a by ivan tkachenko.
Committed on 13/08/2024 at 20:03.
Pushed by ratijas into branch 'master'.

kcm: Fix typo in Kirigami.Theme color property

This was lost in the sauce some time during KF6 porting period, probably
in fa88ce92f9ab5a38b10f82af594edeb77170d44b

M  +1    -1    src/kcm/ui/DeviceList.qml

https://invent.kde.org/plasma/plasma-thunderbolt/-/commit/7de63e92a05d0ecfdd64523843a37ef961deb30a