Bug 480982 - Dolphin icon color stopped respect accent color (in Taskbar)
Summary: Dolphin icon color stopped respect accent color (in Taskbar)
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 24.01.95
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: qt6
: 483403 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-02-07 03:15 UTC by Piotr Mierzwinski
Modified: 2024-03-22 19:51 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
System Settings - colors (29.51 KB, image/png)
2024-02-07 03:15 UTC, Piotr Mierzwinski
Details
System Settings - colors2 (35.20 KB, image/png)
2024-02-07 03:17 UTC, Piotr Mierzwinski
Details
System Settings - colors3 (12.44 KB, image/png)
2024-02-07 03:37 UTC, Piotr Mierzwinski
Details
System Settings - colors5 (37.34 KB, image/png)
2024-02-07 16:38 UTC, Piotr Mierzwinski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Mierzwinski 2024-02-07 03:15:34 UTC
Created attachment 165635 [details]
System Settings - colors

SUMMARY
One week ago my Dolphin icon color which I had in Task bar was in "accent color" (dark green). Since couple days this color became blue.
BTW. Check attached screen, to see set accent color and how not clear is this color presented in dark mode.

STEPS TO REPRODUCE
1. Set any accent color
2. relogin / restart PC
3. 

OBSERVED RESULT
Dolphin icon color is blue

EXPECTED RESULT
Dolphin icon color should be in set accent color

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 6.0.80
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
Comment 1 Piotr Mierzwinski 2024-02-07 03:17:12 UTC
Created attachment 165636 [details]
System Settings - colors2

Check attached screen how looks presentation of accent color after change (in dark mode) - still previous color is visible.
Comment 2 Piotr Mierzwinski 2024-02-07 03:37:22 UTC
Created attachment 165637 [details]
System Settings - colors3

Check attached screenshot.
In dark mode contrast (between text and background) is not verified fpr good visiblility and what user has set is presented, even isn't this good combination. In result if the user chooses the color not carefully then result not always will be as he expected - usually visibility of text will be bad.
Similar case we can find in Spectacle, after we save screenshot we see something like "The screenshot was saved as <name>", where <name> is barely visible.
Comment 3 Doug 2024-02-07 05:52:00 UTC
I cannot reproduce.  Maybe a regression from 6.0?

Operating System: KDE neon Testing Edition
KDE Plasma Version: 6.0.0
KDE Frameworks Version: 6.0.0
Qt Version: 6.6.1
Kernel Version: 6.5.0-15-generic (64-bit)
Graphics Platform: Wayland
Graphics Processor: AMD Radeon Pro WX 3200 Series
Comment 4 Piotr Mierzwinski 2024-02-07 16:30:42 UTC
(In reply to Doug from comment #3)
> I cannot reproduce.  Maybe a regression from 6.0?
> 
> Operating System: KDE neon Testing Edition
> KDE Plasma Version: 6.0.0
> KDE Frameworks Version: 6.0.0
> Qt Version: 6.6.1
> Kernel Version: 6.5.0-15-generic (64-bit)
> Graphics Platform: Wayland
> Graphics Processor: AMD Radeon Pro WX 3200 Series

Please notice I use newer version than you tested.
And yes, maybe this is regression.

And updating some info:
Graphics Platform: Wayland
Graphics Processor: Intel TigerLake-LP GT2 [Iris Xe Graphics]
Comment 5 Piotr Mierzwinski 2024-02-07 16:38:17 UTC
Created attachment 165647 [details]
System Settings - colors5

After I back to my old accent color (green) I found red color between button to change color and radiobutton showing color. Check attached screenshot.
BTW.
My scheme color is: ROUNDED DARK
Comment 6 fin-w 2024-02-08 03:22:17 UTC
I can confirm this in Neon Unstable, Wayland, Dolphin 24.04.70, Plasma 6.0.80, Frameworks 6.0.0, Qt 6.6.1 as well.

Searching for "Dolphin" in the start menu IS showing me "Locations: Locations for Personal Files" with the correct custom colour applied to the Dolphin folder icon, but the other related icons for open Dolphin sessions or the start menu entry for Dolphin itself, are all in the default blue. The icon on Dolphin windows and in the Task Manager on the Panel are all displaying with default blue too.
Comment 7 fin-w 2024-02-08 03:31:59 UTC
With "Plasma Style" set to "Breeze: Follows colour scheme", and any default "Colours" colour scheme (Breeze Classic / Light / Dark), the Dolphin icon ignores custom accent colours. Folders shown within Dolphin itself will respect the custom colour though: the issue seems only with the icon.
Comment 8 Piotr Mierzwinski 2024-02-11 03:53:18 UTC
(In reply to fin-w from comment #7)
> With "Plasma Style" set to "Breeze: Follows colour scheme", and any default
> "Colours" colour scheme (Breeze Classic / Light / Dark), the Dolphin icon
> ignores custom accent colours. Folders shown within Dolphin itself will
> respect the custom colour though: the issue seems only with the icon.

And forgot to mention. My Plasma Style is "ROUNDED COLOR". As far as I remember this style follows by color scheme (at least in Plasma 5). And that's why I installed it some time ago and used long time starting Plasma 5.
Before Plasma 6.1 the color of Dolphin icon placed in TaskBar was as I expected. So for me it looks like regression and that's why reported this.. I didn't change icon of Dolphin. So maybe any update changed this.

> Folders shown within Dolphin itself . ...
This works fine. The color of icons of folders showing in files list by Dolphin are in accent color I set.
Comment 9 Calvin Hoy 2024-03-04 19:15:11 UTC
Same here, on Arch Linux with Plasma 6.0 installed from the extra-testing repository.
Comment 10 Oleg 2024-03-07 20:48:31 UTC
Same on Arch Plasma 6.0.1
Comment 11 breakingspell 2024-03-10 09:18:29 UTC
I found the change that caused this in the Dolphin shortcut file: https://invent.kde.org/system/dolphin/-/merge_requests/710/diffs#diff-content-8346ea2f7146c4784c325a51e6203a052562f928

/usr/share/applications/org.kde.dolphin.desktop: 
"Icon=system-file-manager"
has changed to 
"Icon=org.kde.dolphin"

Changing it back corrects the Dolphin icon accent color in the taskbar. However, the commit notes that it was intended to "install icons at the
correct location", perhaps it's just not theming these default icons as expected?
Comment 12 Antonio Rojas 2024-03-13 07:25:40 UTC
*** Bug 483403 has been marked as a duplicate of this bug. ***
Comment 13 Piotr Mierzwinski 2024-03-15 00:04:35 UTC
(In reply to breakingspell from comment #11)
> I found the change that caused this in the Dolphin shortcut file:
> https://invent.kde.org/system/dolphin/-/merge_requests/710/diffs#diff-
> content-8346ea2f7146c4784c325a51e6203a052562f928
> 
> /usr/share/applications/org.kde.dolphin.desktop: 
> "Icon=system-file-manager"
> has changed to 
> "Icon=org.kde.dolphin"
> 
> Changing it back corrects the Dolphin icon accent color in the taskbar.
> However, the commit notes that it was intended to "install icons at the
> correct location", perhaps it's just not theming these default icons as
> expected?

Thanks for workaround. Unfortunately any next update the most likely will  overwrite it.
Comment 14 breakingspell 2024-03-15 00:28:02 UTC
(In reply to Piotr Mierzwinski from comment #13)
> (In reply to breakingspell from comment #11)
> > I found the change that caused this in the Dolphin shortcut file:
> > https://invent.kde.org/system/dolphin/-/merge_requests/710/diffs#diff-
> > content-8346ea2f7146c4784c325a51e6203a052562f928
> > 
> > /usr/share/applications/org.kde.dolphin.desktop: 
> > "Icon=system-file-manager"
> > has changed to 
> > "Icon=org.kde.dolphin"
> > 
> > Changing it back corrects the Dolphin icon accent color in the taskbar.
> > However, the commit notes that it was intended to "install icons at the
> > correct location", perhaps it's just not theming these default icons as
> > expected?
> 
> Thanks for workaround. Unfortunately any next update the most likely will 
> overwrite it.

Copying the shortcut to ~/.local/share/applications/org.kde.dolphin.desktop overrides the system shortcut, but I guess the problem is underlying, so one would want to take the override out once a fix is in. 

It's interesting because that commit shows the icons were only renamed, (system-file-manager.svg -> org.kde.dolphin.svg), not much else changed there. I wonder if there's a separate Plasma icon theming component that expects the old names and just isn't catching the new ones. It's also odd that the old names even work.
Comment 15 breakingspell 2024-03-22 03:13:36 UTC
Confirmed fixed in 24.02.1, thanks!!
https://invent.kde.org/system/dolphin/-/commit/3a7e54f4b4c0b795279360cbe01d8dc42345607f
Comment 16 fin-w 2024-03-22 19:51:34 UTC
Can also confirm this is fixed in 24.02.1