Bug 480845 - Rendering of Guide Zone / Guide Multi-Export fails when there is a slash in the guide comment
Summary: Rendering of Guide Zone / Guide Multi-Export fails when there is a slash in t...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Rendering & Export (other bugs)
Version First Reported In: 23.08.4
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-04 11:49 UTC by ada
Modified: 2024-02-12 08:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ada 2024-02-04 11:49:21 UTC
SUMMARY
***
I tried to export a sequence of clips with guides at the cuts. One of the guides had a " / " in the guide comment, another one had a slash in between characters. These two guide zones failed to export with the following message

[consumer avformat] Could not open '/home/user/projects/project-folder/C-Cam/shooting-date_projectname-{guide / comment}.mp4'
***


STEPS TO REPRODUCE
1. Create a sequence with guides throughout
2. Make sure one of the guides have a / in the comment
3. Use a Guide Multi-export render

OBSERVED RESULT
The renderer crashes as the file name looks like a path with a folder that does not exist. Not sure if we would get the same result/error with other forbidden characters in the guide comment.

EXPECTED RESULT
The render does not crash. As it is a file system/OS specific bug not sure what the correct way to handle this scenario would be. Perhaps there is a list of chars that are allowed depending on OS and the guide comments are parsed prior to file name generation to replace these characters with something else.

SOFTWARE/OS VERSIONS
Operating System: NixOS 23.11
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.113.0
Qt Version: 5.15.12
Kernel Version: 6.1.70-xanmod1 (64-bit)
Graphics Platform: X11
Processors: 8 × AMD Ryzen Embedded V1605B with Radeon Vega Gfx
Memory: 14.6 GiB of RAM
Graphics Processor: AMD Ryzen Embedded V1605B with Radeon Vega Gfx

ADDITIONAL INFORMATION
Was using the flatpak version when first encountering this error but most likely will be present in nixpkgs version as well as appimage since the error is most likely due to os/filesystem limitations.
Comment 1 Jean-Baptiste Mardelle 2024-02-04 15:08:41 UTC
Git commit c288dab07d836cada8d668944cde088fd4238b33 by Jean-Baptiste Mardelle.
Committed on 04/02/2024 at 15:08.
Pushed by mardelle into branch 'release/24.02'.

Multi guides export: replace slash and backslash in section names to fix rendering

M  +2    -0    src/render/renderrequest.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/c288dab07d836cada8d668944cde088fd4238b33
Comment 2 Jean-Baptiste Mardelle 2024-02-12 08:04:46 UTC
Git commit c6c53a8e642304931a2ad2678db7142abfc88d58 by Jean-Baptiste Mardelle.
Committed on 12/02/2024 at 07:58.
Pushed by mardelle into branch 'release/23.08'.

Multi guides export: replace slash and backslash in section names to fix rendering

M  +2    -0    src/render/renderrequest.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/c6c53a8e642304931a2ad2678db7142abfc88d58