Bug 480554 - Sound theme window hides some icons when resized in French (and probably other locals too)
Summary: Sound theme window hides some icons when resized in French (and probably othe...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_soundtheme (other bugs)
Version First Reported In: 5.92.0
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: Joshua Goins
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-01-30 17:06 UTC by Mickaël STEMMER
Modified: 2024-02-17 01:03 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.0
Sentry Crash Report:


Attachments
Pay attention to the missing low battery and USB icons (823.47 KB, image/png)
2024-01-30 17:06 UTC, Mickaël STEMMER
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mickaël STEMMER 2024-01-30 17:06:54 UTC
Created attachment 165358 [details]
Pay attention to the missing low battery and USB icons

SUMMARY

When resized, the sound theme window will lose some icons in French (and probably other locals with long strings too), much as if it was not responsive.

You can't click them anymore as they phase through their boxes and become hidden by other themes.

STEPS TO REPRODUCE
1. Open system config, go to sound themes
2. Resize the config window, making it bigger or shrinking it will lead to the same result

OBSERVED RESULT

Some icons (sound test) come out of their respective boxes and become hidden by other sound themes.

EXPECTED RESULT

Resizing window should be responsive and the icons should stay in their boxes and move/become smaller

SOFTWARE/OS VERSIONS
Windows: /
macOS: /
Linux/KDE Plasma: Fedora Linux 40
(available in About System)
KDE Plasma Version: 5.92.0
KDE Frameworks Version: 5.248.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
Might happen in some other menus too, still have to check that
Comment 1 Bug Janitor Service 2024-02-16 23:17:58 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3917
Comment 2 Ismael Asensio 2024-02-17 00:32:36 UTC
Git commit 3e1bb77e9ee0a5d3cff71798ba257bfbfc96b7e5 by Ismael Asensio.
Committed on 17/02/2024 at 00:20.
Pushed by iasensio into branch 'master'.

kcms/soundtheme: Fix items overflowing the card

Allow the label to shrink and elide, so it doesn't push the
buttons out of the card's frame, which can happen with larger
fonts or in more verbose languages.

With this also drop the "compact mode" concept and just place
the general preview button above. It simplifies the layout and
avoids UI jumpiness and edge cases.

We cannot currently set a minimum size for the cards right now,
so let's adapt to it the best way possible.
FIXED-IN: 6.0

M  +8    -4    kcms/soundtheme/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/3e1bb77e9ee0a5d3cff71798ba257bfbfc96b7e5
Comment 3 Ismael Asensio 2024-02-17 01:03:20 UTC
Git commit 3a59f73ac8f50d5b0f9a025d02d1f720430011b8 by Ismael Asensio.
Committed on 17/02/2024 at 00:40.
Pushed by iasensio into branch 'Plasma/6.0'.

kcms/soundtheme: Fix items overflowing the card

Allow the label to shrink and elide, so it doesn't push the
buttons out of the card's frame, which can happen with larger
fonts or in more verbose languages.

With this also drop the "compact mode" concept and just place
the general preview button above. It simplifies the layout and
avoids UI jumpiness and edge cases.

We cannot currently set a minimum size for the cards right now,
so let's adapt to it the best way possible.
FIXED-IN: 6.0

(cherry picked from commit 3e1bb77e9ee0a5d3cff71798ba257bfbfc96b7e5)

M  +8    -4    kcms/soundtheme/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/3a59f73ac8f50d5b0f9a025d02d1f720430011b8