Bug 480533 - On fractional scale, tabs have a thin line at the bottom
Summary: On fractional scale, tabs have a thin line at the bottom
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-01-30 11:36 UTC by Jin Liu
Modified: 2024-02-01 15:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (94.37 KB, image/png)
2024-01-30 11:36 UTC, Jin Liu
Details
"application style" kcm (148.45 KB, image/png)
2024-01-30 11:37 UTC, Jin Liu
Details
enlarged (22.59 KB, image/png)
2024-01-30 11:38 UTC, Jin Liu
Details
Tabs at 200% scaling shows no line (19.11 KB, image/png)
2024-01-31 04:41 UTC, Doug
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jin Liu 2024-01-30 11:36:09 UTC
Created attachment 165347 [details]
screenshot

SUMMARY
See attachments. Also, sometimes the active tab cuts a few pixels into the content area.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.0.80
KDE Frameworks Version: 5.249.0
Qt Version: 6.6.1
Kernel Version: 6.7.2-arch1-1 (64-bit)
Graphics Platform: offscreen
Processors: 12 × AMD Ryzen 5 5600H with Radeon Graphics
Memory: 13.5 GiB of RAM
Graphics Processor: AMD Radeon Graphics
Comment 1 Jin Liu 2024-01-30 11:37:00 UTC
Created attachment 165348 [details]
"application style" kcm
Comment 2 Jin Liu 2024-01-30 11:38:18 UTC
Created attachment 165349 [details]
enlarged
Comment 3 Doug 2024-01-31 04:41:22 UTC
Created attachment 165386 [details]
Tabs at 200% scaling shows no line

Can confirm that the lines are not there at 200% scaling.
Comment 4 Akseli Lahtinen 2024-02-01 15:38:59 UTC
Git commit 3a0efff5d64de71333545873447dc3270b103d86 by Akseli Lahtinen.
Committed on 01/02/2024 at 15:38.
Pushed by akselmo into branch 'master'.

Breezestyle: use QRectF instead of QRect, fix tab-bar alignment issues

This adjusts the tab buttons to take the fractional scaling into account.
This also changes QRect to QRectF which allows Qt to do better alignment
when using fractional scaling, causing less flickering with separator lines for example.

M  +52   -60   kstyle/breezehelper.cpp
M  +35   -29   kstyle/breezehelper.h
M  +5    -5    kstyle/breezestyle.cpp

https://invent.kde.org/plasma/breeze/-/commit/3a0efff5d64de71333545873447dc3270b103d86
Comment 5 Akseli Lahtinen 2024-02-01 15:43:17 UTC
Git commit da96e06fb04493a63fcdc4b24953e52aa87206c4 by Akseli Lahtinen.
Committed on 01/02/2024 at 15:39.
Pushed by akselmo into branch 'Plasma/6.0'.

Breezestyle: use QRectF instead of QRect, fix tab-bar alignment issues

This adjusts the tab buttons to take the fractional scaling into account.
This also changes QRect to QRectF which allows Qt to do better alignment
when using fractional scaling, causing less flickering with separator lines for example.


(cherry picked from commit 3a0efff5d64de71333545873447dc3270b103d86)

M  +52   -60   kstyle/breezehelper.cpp
M  +35   -29   kstyle/breezehelper.h
M  +5    -5    kstyle/breezestyle.cpp

https://invent.kde.org/plasma/breeze/-/commit/da96e06fb04493a63fcdc4b24953e52aa87206c4