Bug 480428 - No header or footer in Elisa's Settings or Metadata pages
Summary: No header or footer in Elisa's Settings or Metadata pages
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-28 12:43 UTC by Jack Hill
Modified: 2024-02-21 12:42 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kirigami/-/commit/c6ecdaca33843244067276ba3ebed3e1d17113f4
Version Fixed In:
Sentry Crash Report:

Attachments
Footer before & after the commit (76.65 KB, image/png)
2024-02-12 13:02 UTC, Jack Hill 		Details
with merge request (54.15 KB, image/png)
2024-02-19 11:23 UTC, Marco Martin 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2024-01-28 12:43:59 UTC 
SUMMARY
Not sure what is going on here. The header loader has `active` and `visible` as both true but there are no visible actions. The footer has `active` as true but `visible` as false.

Issue started with this commit https://invent.kde.org/frameworks/kirigami/-/commit/6411c1283eeaaf37561bb76dea3d02078c5abcc8

STEPS TO REPRODUCE
1. Run elisa in mobile mode `QT_QUICK_CONTROLS_MOBILE=1 kdesrc-run elisa`
2. Open the sidebar
3. Open the settings page

OBSERVED RESULT
No header or footer actions

EXPECTED RESULT
Two actions: "Save" and "Cancel" preferably in the footer

SOFTWARE/OS VERSIONS
Qt6 version: 6.6.1
Kirigami version: git master
Elisa version: git master

Operating System: openSUSE Tumbleweed 20240110
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.113.0
Qt Version: 5.15.12
Kernel Version: 6.6.10-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-02-06 23:37:53 UTC 
Elisa is working for me again today, and when I run Elisa in mobile mode as indicated, I don't see the issue. Is it still reproducing for you today, Jack? If so, can you attach screenshots that show the issue, so I can be sure I understanding it correctly?
Comment 2 Jack Hill 2024-02-12 13:02:22 UTC 
Created attachment 165778 [details]
Footer before & after the commit

Still reproducible. I added some debug statements to columnview.cpp, and it seems like the ColumnViewAttached property is never created. I could be wrong though, I don't know anything about how attached properties work. It might be caused by Elisa not setting an initial page to the pagerow.
Comment 3 Nate Graham 2024-02-13 20:56:06 UTC 
Ah, I was opening it the wrong way and getting the desktop dialog. Can reproduce the issue now if I actually follow the steps to reproduce (imagine that!)
Comment 4 Marco Martin 2024-02-16 13:54:00 UTC 
looking into it
Comment 5 Bug Janitor Service 2024-02-19 11:20:58 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1469
Comment 6 Marco Martin 2024-02-19 11:23:06 UTC 
Created attachment 165935 [details]
with merge request

with the above merge request the issue should be fixed
Comment 7 Marco Martin 2024-02-21 12:42:11 UTC 
Git commit c6ecdaca33843244067276ba3ebed3e1d17113f4 by Marco Martin.
Committed on 21/02/2024 at 12:42.
Pushed by mart into branch 'master'.

Fix footer in layers

If a page has actions, in mobile mode make actions as a footer like in
the normal row

M  +87   -8    src/controls/PageRow.qml

https://invent.kde.org/frameworks/kirigami/-/commit/c6ecdaca33843244067276ba3ebed3e1d17113f4