Bug 480356 - Panel spacing between applets becomes huge when unchecking "Fill free space on Panel" in the Task Manager settings
Summary: Panel spacing between applets becomes huge when unchecking "Fill free space o...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-01-26 11:31 UTC by Taro Tanaka
Modified: 2024-01-29 15:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Huge spacing between applets in Panel (63.44 KB, image/png)
2024-01-26 11:31 UTC, Taro Tanaka
Details
Expected result (63.51 KB, image/png)
2024-01-26 11:34 UTC, Taro Tanaka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Taro Tanaka 2024-01-26 11:31:00 UTC
Created attachment 165235 [details]
Huge spacing between applets in Panel

STEPS TO REPRODUCE
1. Create a Default Panel.
2. Open "Icons-only Task Manager Settings" via the context menu.
3. Make sure "Fill free space on Panel" is already checked. (Otherwise you cannot reproduce this.)
4. Uncheck "Fill free space on Panel".

OBSERVED RESULT
Panel spacing between applets becomes huge.

EXPECTED RESULT
Panel has normal spacing between applets and has a big blank space at the end.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE neon Unstable Edition
KDE Plasma Version: 6.0.80
KDE Frameworks Version: 5.249.0
Qt Version: 6.6.1
Comment 1 Taro Tanaka 2024-01-26 11:34:32 UTC
Created attachment 165236 [details]
Expected result
Comment 2 Taro Tanaka 2024-01-26 11:35:25 UTC
I'm going to submit a MR for this.
Comment 3 Bug Janitor Service 2024-01-26 12:07:32 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2012
Comment 4 Nate Graham 2024-01-29 15:58:39 UTC
Git commit 2397753212723130b688547328b3377a5ae1ac5e by Nate Graham, on behalf of Taro Tanaka.
Committed on 29/01/2024 at 15:58.
Pushed by ngraham into branch 'master'.

Panel: Call checkLastSpacer() onWantsToFill{Width,Height}Changed

The `[wantsToFillHeight, wantsToFillWidth]` is not a `bool` but a
`list<bool>`, so the `onWantsToFillSpaceChanged` was never triggered
due to the type mismatch.

CC @niccolove

M  +2    -2    containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/2397753212723130b688547328b3377a5ae1ac5e
Comment 5 Nate Graham 2024-01-29 15:59:02 UTC
Git commit 47c0ce9dfeae6a699454c6e22cdaa482a229c12d by Nate Graham, on behalf of Taro Tanaka.
Committed on 29/01/2024 at 15:58.
Pushed by ngraham into branch 'Plasma/6.0'.

Panel: Call checkLastSpacer() onWantsToFill{Width,Height}Changed

The `[wantsToFillHeight, wantsToFillWidth]` is not a `bool` but a
`list<bool>`, so the `onWantsToFillSpaceChanged` was never triggered
due to the type mismatch.

CC @niccolove


(cherry picked from commit 2397753212723130b688547328b3377a5ae1ac5e)

M  +2    -2    containments/panel/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/47c0ce9dfeae6a699454c6e22cdaa482a229c12d