Bug 480344 - Digital Clock widget has no Israeli Holidays
Summary: Digital Clock widget has no Israeli Holidays
Status: CONFIRMED
Alias: None
Product: frameworks-kholidays
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-01-25 23:19 UTC by Jay Augen
Modified: 2024-01-31 15:25 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
attachment-3272927-0.html (1.23 KB, text/html)
2024-01-29 21:26 UTC, Jay Augen
Details
holiday happening in may (39.90 KB, image/png)
2024-01-31 11:36 UTC, Christophe Marin
Details
attachment-3520013-0.html (1.27 KB, text/html)
2024-01-31 15:25 UTC, Jay Augen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Augen 2024-01-25 23:19:35 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: KDE Neon Testing
(available in About System)
KDE Plasma Version: 5.92.90
KDE Frameworks Version: 5.249.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
Comment 1 Nicolas Fella 2024-01-26 15:23:28 UTC
We do have holiday data for Israel, both in English and Hebrew: https://invent.kde.org/frameworks/kholidays/-/blob/master/holidays/plan2/holiday_il_en-us?ref_type=heads

At least "Victory Day" shows up in the applet for me, but e.g. Yom Kippur does not.

My suspicion is that this is because "Victory Day" is specified in terms of the gregorian calendar but the others are based on the hebrew calendar
Comment 2 Nicolas Fella 2024-01-26 15:25:51 UTC
I'm not sure whether this is a problem with the KHolidays framework or how it is used
Comment 3 Allen Winter 2024-01-29 20:38:52 UTC
There are Israel holidays for sure in the kholidays library
Comment 4 Jay Augen 2024-01-29 21:26:34 UTC
Created attachment 165327 [details]
attachment-3272927-0.html

They do not show up in Kubuntu, KDE Neon, KDE Neon Testing or Manjaro.

On Mon, Jan 29, 2024 at 10:38 PM Allen Winter <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=480344
>
> Allen Winter <winter@kde.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |winter@kde.org
>
> --- Comment #3 from Allen Winter <winter@kde.org> ---
> There are Israel holidays for sure in the kholidays library
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 5 Christophe Marin 2024-01-31 11:36:01 UTC
Created attachment 165393 [details]
holiday happening in may

I see them on openSUSE.  Since I use a gregorian calendar, holidays using the hebrew one won't be displayed.

Can you check if you see an event on April, 10 or may, 9?
Comment 6 Jay Augen 2024-01-31 15:25:40 UTC
Created attachment 165399 [details]
attachment-3520013-0.html

I am also using a Gregorian calendar.  I see no event on April 10, but on
May 9 I see Victory Day.  That is it for the entire year.

On Wed, Jan 31, 2024 at 1:36 PM Christophe Marin <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=480344
>
> --- Comment #5 from Christophe Marin <christophe@krop.fr> ---
> Created attachment 165393 [details]
>   --> https://bugs.kde.org/attachment.cgi?id=165393&action=edit
> holiday happening in may
>
> I see them on openSUSE.  Since I use a gregorian calendar, holidays using
> the
> hebrew one won't be displayed.
>
> Can you check if you see an event on April, 10 or may, 9?
>
> --
> You are receiving this mail because:
> You reported the bug.