Bug 480338 - "Overwrite File" dialog layout is broken
Summary: "Overwrite File" dialog layout is broken
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-01-25 20:50 UTC by Nicolas Fella
Modified: 2024-02-27 16:47 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/knewstuff/-/commit/dbf0f45bd42c35cc51a66473edca207dab5cc47c
Version Fixed In: Frameworks 6.1

Attachments
Screenshot (413.36 KB, image/png)
2024-01-25 20:50 UTC, Nicolas Fella 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Fella 2024-01-25 20:50:08 UTC 
Created attachment 165216 [details]
Screenshot

STEPS TO REPRODUCE
1. In Dolphin go to Configure Dolphin > Context Menu 
2. Download new Services
3. Try to install something with a file you already have

OBSERVED RESULT
A dialog informing that such a file already exists, but too small with text overflowing. See screenshot

EXPECTED RESULT
A properly sized dialog

SOFTWARE/OS VERSIONS
KDE Plasma Version: master
KDE Frameworks Version: master
Qt Version: 6.7
Comment 1 Nate Graham 2024-01-29 20:18:55 UTC 
aaaaaaaaaaaaaaa
Comment 2 Akseli Lahtinen 2024-02-27 16:31:15 UTC 
Git commit dbf0f45bd42c35cc51a66473edca207dab5cc47c by Akseli Lahtinen.
Committed on 27/02/2024 at 16:31.
Pushed by akselmo into branch 'master'.

Set questionAsker implicit sizes, set maxWidth to dialog width

Set the size of questionAsker so it won't try to take the smallest amount of space available.

Also make sure text and other elements end at dialog boxes width.

The width has minimum value to make sure the box doesn't get too small inside smaller windows.
Height is calculated from text and footer.

| Before | After |
| ------ | ------ |
|    ![image](/uploads/47fb020ec8f0ba1b47f26d551514edd5/image.png)    |     ![image](/uploads/09363de050911fc19169f2cf3696fdfd/image.png)   |

M  +5    -3    src/qtquick/qml/QuestionAsker.qml

https://invent.kde.org/frameworks/knewstuff/-/commit/dbf0f45bd42c35cc51a66473edca207dab5cc47c