Bug 480287 - Browser login for openconnect has fixed size
Summary: Browser login for openconnect has fixed size
Status: ASSIGNED
Alias: None
Product: plasma-nm
Classification: Plasma
Component: applet (show other bugs)
Version: 5.92.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Rahul Rameshbabu
URL:
Keywords: qt6, wayland
: 482874 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-01-24 20:33 UTC by Paul de Vrieze
Modified: 2024-05-15 12:31 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the dialog (54.72 KB, image/png)
2024-01-24 21:04 UTC, Paul de Vrieze
Details
Issue seen in Wayland (2.09 MB, image/png)
2024-02-05 05:05 UTC, Rahul Rameshbabu
Details
Issue not seen in X11 (2.11 MB, image/png)
2024-02-05 05:05 UTC, Rahul Rameshbabu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul de Vrieze 2024-01-24 20:33:06 UTC
SUMMARY

The webview for the openconnect browser authentication (for openconnect/anyconnect - with MS SAML auth) has a fixed size (can not be resized) as well as no scroll bars. Unfortunately the login page used by my provider has a reasonably large minimum size and therefore most of the login dialog is invisible.

STEPS TO REPRODUCE
1. Try to connect to the VPN (using anyconnect)
2. Be prompted with the SAML login page

OBSERVED RESULT
The page does not scroll (some bits with selection do allow it) and can not be used reasonably. 

EXPECTED RESULT
The page can be seen properly (ideally resized to display the page with "minimum" size), but at least allow scrolling and resizing of the login window.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Gentoo / Plasma 5.92.0
(available in About System)
KDE Plasma Version: 5.92.0
KDE Frameworks Version: 5.248
Qt Version: 6.6.1

ADDITIONAL INFORMATION
- For some reason it does not appear possible to trigger the login for a second time.
- Logging in with nm-applet (gnome applet) works correctly.
Comment 1 Paul de Vrieze 2024-01-24 20:59:44 UTC
I had a bit of a look at the code. The code sets the webengine widget to 640x480: (https://invent.kde.org/plasma/plasma-nm/-/blob/Plasma/6.0/vpn/openconnect/openconnectauth.cpp#L604)
But the UI file restricts the full widget to 360x360 (https://invent.kde.org/plasma/plasma-nm/-/blob/Plasma/6.0/vpn/openconnect/openconnectauth.ui#L9).
Note that (on wayland) the window class is seen as kded6 (with fixed maximum size) - attempting to force the maximum size with kwin doesn't work.
Comment 2 Paul de Vrieze 2024-01-24 21:04:43 UTC
Created attachment 165199 [details]
Screenshot of the dialog

This shows the issue. For some strange reason even forcing window geometry doesn't change the size.
Comment 3 Nicolas Fella 2024-01-24 22:26:33 UTC
CC'ing the author of the relevant code
Comment 4 Rahul Rameshbabu 2024-01-25 17:51:55 UTC
This issue is introduced when transitioning from X to Wayland. The UI file is not "restricting" the geometry to 360x360 but setting the initial default geometry to this size. The code injects a new widget when SAML (SSO) capabilities are detected from the VPN gateway and changes the geometry appropriately due to the QLayouts used on the ui component for the auth dialog.

You can see screenshots of the resize working correctly in the original authorship of this feature in the original MR.

https://invent.kde.org/plasma/plasma-nm/-/merge_requests/208

This issue was also reported in a relevant MR.

https://invent.kde.org/plasma/plasma-nm/-/merge_requests/316#note_848258

Hoping to submit a fix for this in Wayland this weekend.
Comment 5 Paul de Vrieze 2024-01-26 18:24:45 UTC
I actually used blind entry to actually be able to log in. Today I logged in again, and somehow the window was larger so I could see most of the relevant parts of the web page (still not perfect, but...).
Comment 6 Rahul Rameshbabu 2024-02-05 05:05:07 UTC
Created attachment 165553 [details]
Issue seen in Wayland
Comment 7 Rahul Rameshbabu 2024-02-05 05:05:38 UTC
Created attachment 165554 [details]
Issue not seen in X11
Comment 8 Rahul Rameshbabu 2024-02-05 05:08:33 UTC
Like I mentioned previously, this issue is only seen in Wayland. Hoping to have this resolved soon.
Comment 9 Bug Janitor Service 2024-02-10 07:24:00 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/329
Comment 10 Rahul Rameshbabu 2024-03-08 14:58:10 UTC
*** Bug 482874 has been marked as a duplicate of this bug. ***
Comment 11 deadmeu 2024-04-02 00:52:33 UTC
Could the priority of this be increased? This issue is blocking the use of the feature entirely.
Comment 12 deadmeu 2024-04-02 01:21:47 UTC
Actually, after trying again, this seems to no longer be an issue.
Comment 13 Dmitrii Chermnykh 2024-04-02 06:48:11 UTC
(In reply to deadmeu from comment #12)
> Actually, after trying again, this seems to no longer be an issue.

There is an open MR with the fix
Comment 14 Fred Sundvik 2024-04-03 21:11:58 UTC
> Actually, after trying again, this seems to no longer be an issue.

For me it's definitely still an issue:

With QT 6.6.2, the window can not be resized as reported in here in this issue.
With QT 6.6.3 the login dialog is not shown at all, as reported in https://bugs.kde.org/show_bug.cgi?id=484874
Comment 15 Fred Sundvik 2024-04-20 13:33:16 UTC
I think this was fixed by QT 6.7, now the window is properly resized and shown. I'm not completely sure if that was the fix, but I did not see any relevant KDE updates when it was fixed for me, only the QT 6.7 update on Arch Linux.