SUMMARY The merge request https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3330 removed the "Add to Panel (widget)" context menu action for apps on Kickoff when a task manager is available because it was essentially doing the same as "Pin to Task Manager". However, it forgot to remove the same button for apps on the Favorites view. STEPS TO REPRODUCE 1. Open Kickoff on the Favorites view (make sure to have a task manager like IOTM) 2. Right-click one of the applications there OBSERVED RESULT The "Add to Panel (widget)" context menu action is still available. EXPECTED RESULT It should be removed when a task manager is available, just like it was for apps on other categories on Kickoff. SOFTWARE/OS VERSIONS KDE Plasma Version: 6.0.80 KDE Frameworks Version: 5.249.0 Qt Version: 6.6.1
the one thing i can reproduce, is that the apps that are already pinned to the task manager do have add to panel (widget) while the ones that are not pinned yet, have the pin to taskmanager entry what should probably happen is the already pinned ones making the extra context menu they have on the panel, to either unpin if only one activity, or add to specific activity if more than one
Yeah, can reproduce but only for apps that are also pinned to the Task Manager. This is fairly silly IMO since for these apps there's even less of a reason to add them to the panel as a launcher.
I think the problem is that ContainmentInterface::mayAddLauncher() returns false here since the app is already pinned. What we probably want is a function that returns whether it's *theoretically* possible to pin the app to a Task Manager, not whether it's *currently* possible to do it.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2000
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3819
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3826
Git commit 709dbb816d39cb0c6fbeb162031d6d6fc14e89ef by Marco Martin. Committed on 26/01/2024 at 16:48. Pushed by mart into branch 'master'. Api to know whether an applet supportslaunchers Right now when an app is already pinned to the taskmanager, kickoff thinks as is not pinnable anymore, adding the icon widget to the panel is still needed. This removes both the pin and the add icon to panel actions when is already pinned On the long term i would like to have the same per activity context menu that the taskbar itself has, but since it would be a more invasive change, should be at least for 6.1 Depends on https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3819 or https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3826 FIXED-IN: 6.0 M +8 -0 applets/taskmanager/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/709dbb816d39cb0c6fbeb162031d6d6fc14e89ef
Git commit 7405d2c871f31a238036db560863be9a664355b0 by Marco Martin. Committed on 26/01/2024 at 16:48. Pushed by mart into branch 'master'. Hide pin to taskmanager when already pinned Right now when an app is already pinned to the taskmanager, kickoff thinks as is not pinnable anymore, adding the icon widget to the panel is still needed. This removes both the pin and the add icon to panel actions when is already pinned On the long term i would like to have the same per activity context menu that the taskbar itself has, but since it would be a more invasive change, should be at least for 6.1 M +5 -2 applets/kicker/plugin/actionlist.cpp M +39 -3 applets/kicker/plugin/containmentinterface.cpp M +2 -0 applets/kicker/plugin/containmentinterface.h https://invent.kde.org/plasma/plasma-workspace/-/commit/7405d2c871f31a238036db560863be9a664355b0
Git commit 8fceb1e8f5fafd6689f6fc56997904cd3c441860 by Marco Martin. Committed on 26/01/2024 at 16:55. Pushed by mart into branch 'Plasma/6.0'. Hide pin to taskmanager when already pinned Right now when an app is already pinned to the taskmanager, kickoff thinks as is not pinnable anymore, adding the icon widget to the panel is still needed. This removes both the pin and the add icon to panel actions when is already pinned On the long term i would like to have the same per activity context menu that the taskbar itself has, but since it would be a more invasive change, should be at least for 6.1 M +5 -2 applets/kicker/plugin/actionlist.cpp M +39 -3 applets/kicker/plugin/containmentinterface.cpp M +2 -0 applets/kicker/plugin/containmentinterface.h https://invent.kde.org/plasma/plasma-workspace/-/commit/8fceb1e8f5fafd6689f6fc56997904cd3c441860
Git commit 75c6a35a48fd112068209983507714484d3fa7a3 by Marco Martin. Committed on 26/01/2024 at 16:56. Pushed by mart into branch 'Plasma/6.0'. Api to know whether an applet supportslaunchers Right now when an app is already pinned to the taskmanager, kickoff thinks as is not pinnable anymore, adding the icon widget to the panel is still needed. This removes both the pin and the add icon to panel actions when is already pinned On the long term i would like to have the same per activity context menu that the taskbar itself has, but since it would be a more invasive change, should be at least for 6.1 Depends on https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3819 or https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3826 FIXED-IN: 6.0 M +8 -0 applets/taskmanager/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/75c6a35a48fd112068209983507714484d3fa7a3