Bug 480090 - Plasma 5.27 should warn users about upcoming removal of classical custom shortcuts in Plasma 6
Summary: Plasma 5.27 should warn users about upcoming removal of classical custom shor...
Status: RESOLVED INTENTIONAL
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (other bugs)
Version First Reported In: 5.27.10
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-20 11:04 UTC by Maximilian Böhm
Modified: 2024-02-15 05:52 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maximilian Böhm 2024-01-20 11:04:08 UTC
Plasma 5.27 should warn users about upcoming removal of classical custom shortcuts in Plasma 6.

If should detect if there are custom shortcuts defined and display a persistent notification on login about the removal with a hint how to recreate them using the newer Shortcuts KCM.

Else the removal will negatively surprise many users after the Plasma 6 upgrade.
Just do it and prevent hassle.
Comment 1 Bug Janitor Service 2024-01-23 22:57:45 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kglobalacceld/-/merge_requests/37
Comment 2 Nicolas Fella 2024-01-26 13:30:03 UTC
Git commit 6c6ce65186a791ef3ac0ba38924cd15c76c80f34 by Nicolas Fella.
Committed on 26/01/2024 at 14:26.
Pushed by nicolasfella into branch 'master'.

Migrate command shortcuts from khotkeys

khotkeys is finally retired, but users may have a number of existing shortcuts.

While KGlobalAccel has no equivalent for window actions and mouse gestures we
do for command shortcuts, so let's migrate them to kglobalaccel proper.

kglobalaccel already manages these, but the actual execution still resided in
khotkeys.

To fix this, at startup, read the saved shortcuts from khotkeys and create desktop
files for them. This covers command actions as well as DBus actions (since those
can be trivially transformed into a command).

This has the benefit of cleaning out the awkward "Custom Shortcut Service" section
in the KCM.

M  +7    -0    CMakeLists.txt
M  +2    -0    src/CMakeLists.txt
M  +77   -0    src/globalshortcutsregistry.cpp
M  +1    -0    src/globalshortcutsregistry.h

https://invent.kde.org/plasma/kglobalacceld/-/commit/6c6ce65186a791ef3ac0ba38924cd15c76c80f34
Comment 3 Nicolas Fella 2024-01-26 13:48:32 UTC
Git commit e80001ecdf8066a25f3a10481c597a7904c82e36 by Nicolas Fella.
Committed on 26/01/2024 at 14:48.
Pushed by nicolasfella into branch 'Plasma/6.0'.

Migrate command shortcuts from khotkeys

khotkeys is finally retired, but users may have a number of existing shortcuts.

While KGlobalAccel has no equivalent for window actions and mouse gestures we
do for command shortcuts, so let's migrate them to kglobalaccel proper.

kglobalaccel already manages these, but the actual execution still resided in
khotkeys.

To fix this, at startup, read the saved shortcuts from khotkeys and create desktop
files for them. This covers command actions as well as DBus actions (since those
can be trivially transformed into a command).

This has the benefit of cleaning out the awkward "Custom Shortcut Service" section
in the KCM.
(cherry picked from commit 6c6ce65186a791ef3ac0ba38924cd15c76c80f34)

M  +7    -0    CMakeLists.txt
M  +2    -0    src/CMakeLists.txt
M  +77   -0    src/globalshortcutsregistry.cpp
M  +1    -0    src/globalshortcutsregistry.h

https://invent.kde.org/plasma/kglobalacceld/-/commit/e80001ecdf8066a25f3a10481c597a7904c82e36
Comment 4 Maximilian Böhm 2024-01-26 20:45:55 UTC
I don’t quite understand what this 'migration' does. It does save the actions as .desktop files, but where? How are migrating users informed about the place of this 'backup'? If it is the desktop, what about users who have chosen against the desktop with folder view?
And what about the key combos? You might have a couple shortcuts defined you don’t actually mentally remember, but can remember muscularly. When you upgrade to Plasma 6 with such old shortcuts, you would have to recreate them by looking into the .desktop files somewhere but you wouldn’t know what key combos they previously have had.
Comment 5 Nate Graham 2024-02-15 05:52:37 UTC
It's too late at this point to add extra messaging; Plasma 5 has been feature-frozen and string-frozen for ages. There's been messaging around it already. The migration code Nicolas added should attempt to move KHotkeys shortcuts into the new KGlobalAccel service. That's the best we can do at this point I think.