Bug 479976 - Unable to access video controls in video viewer with a touch screen
Summary: Unable to access video controls in video viewer with a touch screen
Status: RESOLVED FIXED
Alias: None
Product: PlasmaTube
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Linus Jahn
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-18 03:16 UTC by Devin Lin
Modified: 2024-04-07 00:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Lin 2024-01-18 03:16:31 UTC
SUMMARY
Tapping on a playing video seems to just pause and unpause the video, I can't see the player controls.

STEPS TO REPRODUCE
1. Open the app
2. Open a video
3. Tap on the video playing

OBSERVED RESULT
It pauses the video rather than showing the player controls.

If this is related to TapHandler, I think the problem is that it seems kinda broken in Qt6 and does not filter properly by device (ex. touchscreen vs mouse). Imo we shouldn't have tap to pause even with a mouse, we can just use the player controls

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Joshua Goins 2024-04-07 00:53:51 UTC
Git commit ceaae4d494ca244bf9f292d5a49e320dba0e9556 by Joshua Goins.
Committed on 07/04/2024 at 00:53.
Pushed by redstrate into branch 'release/24.02'.

Fix video controls touch input

Now the enter/exit events are ignored for video controls, causing them
to hide too soon when trying to make them appear via touch.

M  +13   -6    src/ui/videoplayer/VideoPlayer.qml

https://invent.kde.org/multimedia/plasmatube/-/commit/ceaae4d494ca244bf9f292d5a49e320dba0e9556