Bug 479925 - visual marker for multi-selectable grid view items
Summary: visual marker for multi-selectable grid view items
Status: RESOLVED FIXED
Alias: None
Product: xdg-desktop-portal-kde
Classification: Plasma
Component: general (show other bugs)
Version: 5.92.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-17 00:05 UTC by fanzhuyifan
Modified: 2024-01-21 13:43 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/eef3f4fdbda6f14c5bd38811a25bf12e248fccfa
Version Fixed In: 6.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description fanzhuyifan 2024-01-17 00:05:48 UTC 
"we probably also need some kind of visual marker to differentiate the grid view items that will get activated by a single-click, and the ones that will be selected with a single click, and activated with a double-click or a click on the "Apply" button. Maybe for these, we should include little checkboxes in the corner so it's obvious that they're selectable and you can select more than one at a time, and that's why they don't activate on single-click"

See https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/261#note_851651
Comment 1 Bug Janitor Service 2024-01-17 21:23:28 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/263
Comment 2 Nate Graham 2024-01-18 17:23:58 UTC 
Git commit eef3f4fdbda6f14c5bd38811a25bf12e248fccfa by Nate Graham.
Committed on 18/01/2024 at 18:21.
Pushed by ngraham into branch 'master'.

ScreenChooserDialog: overhaul interaction

Requires https://invent.kde.org/frameworks/kirigami/-/merge_requests/1432.

Right now this dialog has two modes: multi-select and single-select. The
active mode is currently unclear, since nothing communicates whether the
screen and window cards are multi-selectable or not. And in both modes,
cards have no hover feedback, which is inconsistent with the KDE style
for interactive UI elements.

This commit fixes those issues by refining the UI in various ways:
- Add hover feedback
- Use the new "I have a checkbox now" styling for checkable cards when
  in  the multi-select use case
- In single-selection mode, select on single-click and hide the Share
  and Cancel buttons, since they're no longer needed. This matches the
  behavior of the App Chooser dialog, which works in the same way
FIXED-IN: 6.0

M  +2    -0    src/PipeWireDelegate.qml
M  +46   -18   src/ScreenChooserDialog.qml

https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/eef3f4fdbda6f14c5bd38811a25bf12e248fccfa