Bug 479852 - Select all photos when exporting an album
Summary: Select all photos when exporting an album
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-Google (show other bugs)
Version: 8.2.0
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-15 15:29 UTC by chimney@thespicers.net
Modified: 2024-01-30 12:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.3.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description chimney@thespicers.net 2024-01-15 15:29:12 UTC
If you right-click on an album and select "Export to Google Photos...", the initial photo list to be exported to Google only contains the first photo in the album. At this point there is no simple way to add other photos from the album - the + button in the dialog opens a native file browser on the platform's default Pictures folder. I would expect that when exporting an album, the default selection of photos to export would be all the photos in that album.

A workaround is to select an album, then do Edit->Select All, then right-click on the album and select Export. I do not find this very intuitive.
Comment 1 Maik Qualmann 2024-01-15 16:42:35 UTC
If you want to copy all files in Windows Explorer, you must select them all. There is also no "copy all" function in Windows Explorer. Selecting all files (CTRL-A) or via mouse click or menu is a standard process.

Maik
Comment 2 chimney@thespicers.net 2024-01-15 16:59:21 UTC
Please note, I am referring to the initial population of the list of files in digiKam's built-in export dialog. I do not believe this behaviour is at all OS dependent.

My references to Edit->Select All refer to digiKam's UI.
Comment 3 caulier.gilles 2024-01-15 17:01:49 UTC
From icon view : select no item.

Start Google Export tool : All items from current album will be proposed.

Gilles Caulier
Comment 4 chimney@thespicers.net 2024-01-16 11:46:15 UTC
In Thumbnails view I see the behaviour described in the comment above. However, also in Thumbnails view:

Left-click to select a new album, then from the main menu Export->Export to Google Photos: Only the first photo from the album is proposed.

Right-click on a new album and choose Export->Export to Google Photos from the context menu: Only the first photo from the album is proposed.

If found this behaviour very confusing when I first encountered it and had to ask for help to discover how to export all the photos in the album.
Comment 5 caulier.gilles 2024-01-16 12:09:59 UTC
Well, if you want to export from album view, use icon-view popup menu, do not switch in preview mode to visualize only one item and use thumbnail pop-up menu.

The behavior is logic:

- icon view : album view with multiple selections.
- thumbnail view : preview mode with only one item selection.

Gilles Caulier
Comment 6 Maik Qualmann 2024-01-16 18:44:03 UTC
Ok, I understand, you use the export via the context menu of the album tree view. I've never used that before. We currently cannot distinguish whether the export is started via the album tree view or item view, we always use the selected images or all in the album if none was selected.

Maik
Comment 7 chimney@thespicers.net 2024-01-17 10:21:23 UTC
I'm a bit confused about what is meant by the icon view - do you mean the Thumbnails view?

As I am looking to export albums, my main navigation is done using the Albums list on the left, reached by clicking the Albums tag. Clicking any album in this list causes the Thumbnails view to be shown on the right and automatically selects the first item in the album. The same happens if you right-click on an album.

I now realise It is actually this initial selection that is the cause of my issue. Because left- or right-clicking an album always causes at least one item in it to be selected, the export then only acts on that one item. digiKam's interface is quite similar to most file explorers, but this selection behaviour is unusual and I would argue is counter-intuitive. Generally, navigating into a folder does not cause any selection to be made within that folder - the user has to explicitly click a file/image in order to select it. With digiKam, to export all items in an album you have to click the Album and then manually de-select the item that was selected automatically.

The auto-selection behaviour severely limits the usefulness of the right-click Export Album option as this results in only one item being selected for the export.

Why does digiKam change the selection when you click on an album?
Comment 8 Maik Qualmann 2024-01-17 10:43:52 UTC
Yes, the fact that we mark the first image is controversial and we also have a bug report about it. However, we don't want the right sidebar to be inactive the first time it is accessed, which users would find annoying.
By the way, digiKam even remembers the selection in the album if it has been changed.
I have found a solution to your problem with the album selection when exporting, it comes...

Maik
Comment 9 Maik Qualmann 2024-01-17 19:12:46 UTC
Git commit 2acca9dbc6d3d0c02ca43cb300b11d8e95e39a95 by Maik Qualmann.
Committed on 17/01/2024 at 20:11.
Pushed by mqualmann into branch 'master'.

export all album images via context menu from the album tree view
FIXED-IN: 8.3.0

M  +1    -1    NEWS
M  +5    -0    core/app/items/utils/contextmenuhelper_actions.cpp
M  +10   -0    core/app/items/utils/contextmenuhelper_p.h
M  +3    -4    core/app/items/utils/contextmenuhelper_tools.cpp
M  +4    -1    core/libs/dplugins/core/dplugingeneric.cpp
M  +4    -0    core/libs/dplugins/iface/dinfointerface.h
M  +7    -6    core/libs/dplugins/widgets/ditemslist.cpp

https://invent.kde.org/graphics/digikam/-/commit/2acca9dbc6d3d0c02ca43cb300b11d8e95e39a95
Comment 10 Maik Qualmann 2024-01-17 19:40:16 UTC
Git commit 6e0897065f4d2a3dc90cbb87e856517fa7e17fe2 by Maik Qualmann.
Committed on 17/01/2024 at 20:39.
Pushed by mqualmann into branch 'master'.

use enum for more universality of the data container

M  +1    -1    core/app/items/utils/contextmenuhelper_actions.cpp
M  +1    -1    core/app/items/utils/contextmenuhelper_tools.cpp
M  +7    -0    core/libs/dplugins/core/dpluginaction.h
M  +1    -1    core/libs/dplugins/core/dplugingeneric.cpp

https://invent.kde.org/graphics/digikam/-/commit/6e0897065f4d2a3dc90cbb87e856517fa7e17fe2
Comment 11 chimney@thespicers.net 2024-01-30 12:36:14 UTC
With the 28/01/2024 13:06 8.3.0 snapshot I can confirm that all photos in the album are now selected when I right-click on an album and select Export to Google Photos from the context menu. Thanks!